Repository navigation
E2E: flush live-test markers to disk before forcing a host reset - #322
Merged
Merged
Conversation
Run valupd-1103b wrote the delay-before-ready marker with tee and then
reset the stable VM. The write had not reached disk, so after boot the
marker was empty and the readiness shim refused on int(""). The three
markers written ahead of a reset now end with sync, and a test pins it.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
15 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live E2E run
valupd-1103bpassed 14 steps, then failed at "reset at durable may_have_run and reconcile exact A on boot":The controller writes
delay-before-ready.<archive>withteeand then forces a GCP instance reset. The data had not reached disk, so after boot the file existed but was empty. Harness only; the validator's own boot reconcile printedCATHEDRAL_VALIDATOR_UPDATE_RECONCILED.delay-before-readyfor A and B,fail-before-ready.${target}) now end with&& sudo sync.test_live_test_markers_reach_disk_before_a_host_resetpins it.pytest -q tests/thin/test_live_update_e2e_controller.py: 30 passed.Note
Low Risk
Test harness script and a thin controller regression test only; no production updater or validator runtime paths.
Overview
Fixes a live E2E harness flake where
delay-before-ready(and related) files were written withteeand then the controller forced a GCP instance reset before the data hit disk. After reboot the path existed but was empty, which made the no-chain readiness shim fail withinvalid literal for int() with base 10: ''.The controller now appends
&& sudo syncon all three remote writes that precede a reset or crash boundary:delay-before-readyfor archive A and B on the stable host, andfail-before-ready.${target}in the rescue crash path.test_live_test_markers_reach_disk_before_a_host_resetlocks in that those three lines inlive_validator_update_e2e.shalways include sync. Production validator behavior is unchanged; this is harness-only durability.Reviewed by Cursor Bugbot for commit aa12b65. Bugbot is set up for automated code reviews on this repo. Configure here.