Repository navigation
Offer a review's fix only where it can run, and log a refusal once - #187
Closed
madskronborg wants to merge 1 commit into
Closed
madskronborg wants to merge 1 commit into
madskronborg wants to merge 1 commit into
Conversation
A review offered Fix findings for a target with no branch to fix, refused every answer the same way, and replays wrote the refusal again each time. The review now asks the host before its first menu whether the reviewed branch can be established, by the checkout's own resolution and cutting nothing, and withholds what cannot run, naming why. A fix refused when it starts stands for the rest of the Run, and each refusal is recorded inside the Activity that met it. Closes #185.
Collaborator
Author
|
Superseded by #197 (merged, released in 0.93.0), which carries the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review now checks whether a fix can run before its first question, and offers only the fix options that can. Before this,
reviewoffered "Fix findings" and "Fix findings in a full implement run" for every target. For a target with no branch to fix, for exampleHEAD, or a merge request reviewed from a checkout with no remote, the fix was refused only after it was chosen. The menu then came back with the same options, and each refusal was logged again on every replay.host.reviewedBranch(runId)gives the reviewed branch, or the reason there is none, in the same words the checkout uses. It cuts and records nothing.docs/workflows.mdanddocs/sdk.mddescribe the new behaviour.Closes #185.
Verification: on the branch as it stands,
regression,regression-both-idsandtypecheckpassed (by agent). Collie'scheckfailed, andreview-scenarioswas unstable.Verifications this run is held to:
/home/mk/.local/share/mise/shims/bun run check(in/home/mk/.herdr/worktrees/.collie/madskronborg/review-offers-fix-only-where-it-can-run)The three gate-fix rounds after the last review were checked by their own tests and dispositions, not by a reviewer. They changed no code:
regressionon the final tree. It also corrected an earlier claim: the "release on github … fix round" failure was not proved to exist on the base, because the "base" run had actually run in this branch's checkout.regressionwith the same command as the failing reproduction.check.Left open as non-blocking:
reviewedBranch, and the scenario passed in both full gate runs.Not settled by the run
reviewedBranchand returns the newReviewedBranchtype ({ branch } | { refused }). It is added to the SDK's Host and to the engine's author-facing declaration, and it shares one row/launch/target reader (reviewing) withcheckoutReviewed.collie verifyruns only there, and putting the base's files into the checkout was refused.