Skip to content

Serve the criteria hand-back scenarios from the HTTP fake forge - #208

Merged
madskronborg merged 1 commit into
masterfrom
madskronborg/fix-red-master-after-198-9355df70-releas-zfzuzr
Oct 26, 2026
Merged

madskronborg merged 1 commit into
masterfrom
madskronborg/fix-red-master-after-198-9355df70-releas-zfzuzr

Conversation

@madskronborg

Copy link
Copy Markdown
Collaborator

Fixes the master CI red after #198 (runs 40283961729 and 40284073690). #198 was written before #194 moved Collie's forge operations onto HTTP with the CLI's login. Its three criteria hand-back scenarios in test/support/baseline.ts still stubbed the glab CLI, so the forge reads now made over HTTP were never answered and six tests (three scenarios, each under the shipped and an unrelated id) timed out with not yet. They now use noGitlabMrs(bin), the HTTP fake forge every other scenario uses. Test-only: three lines, no src/ change, no assertion or timeout changed.

On the branch as it stands, Collie's own criteria-handback-tests passed and its check failed on two flakes (below); the agent's earlier regression run (6 failing on f85b15f, 6 passing after), typecheck, format-lint and lint ran on an earlier tree.

Verifications this run is held to:

  • criteria-handback-tests: /home/mk/.local/share/mise/shims/bun test test/baseline.test.ts test/baseline-unrelated.test.ts -t criteria hand-back (in the worktree)
  • check: /home/mk/.local/share/mise/shims/bun run check (in the worktree)

Not settled by the run

  • check: the account is told again when Desktop retells it, with each harness's list as it is then (test/flock-chat-turns.test.ts) failed, then passed when run again alone on the same tree — a Flake, so this Run has not settled it.
  • check: two clients of one host read the same board (test/board-stream.test.ts) failed, then passed when run again alone on the same tree — a Flake, so this Run has not settled it.

#198 was written before #194 moved forge reads onto HTTP, so its three
scenarios still stubbed the glab CLI and their forge reads went
unanswered, leaving master red.
@madskronborg madskronborg self-assigned this Oct 26, 2026
@madskronborg
madskronborg merged commit 03f4e1c into master Oct 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant