Repository navigation
Serve the criteria hand-back scenarios from the HTTP fake forge - #208
Merged
madskronborg merged 1 commit intoOct 26, 2026
Merged
madskronborg merged 1 commit into
madskronborg merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the master CI red after #198 (runs 40283961729 and 40284073690). #198 was written before #194 moved Collie's forge operations onto HTTP with the CLI's login. Its three criteria hand-back scenarios in
test/support/baseline.tsstill stubbed theglabCLI, so the forge reads now made over HTTP were never answered and six tests (three scenarios, each under the shipped and an unrelated id) timed out withnot yet. They now usenoGitlabMrs(bin), the HTTP fake forge every other scenario uses. Test-only: three lines, nosrc/change, no assertion or timeout changed.On the branch as it stands, Collie's own
criteria-handback-testspassed and itscheckfailed on two flakes (below); the agent's earlierregressionrun (6 failing on f85b15f, 6 passing after),typecheck,format-lintandlintran on an earlier tree.Verifications this run is held to:
/home/mk/.local/share/mise/shims/bun test test/baseline.test.ts test/baseline-unrelated.test.ts -t criteria hand-back(in the worktree)/home/mk/.local/share/mise/shims/bun run check(in the worktree)Not settled by the run