Repository navigation
Move the logger mock to a loggertest package - #56
Merged
Merged
Conversation
…consumer binaries
LauJosefsen
approved these changes
Oct 21, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logger/mock.go was a non-test file importing testify/mock, so every binary using the logger package linked testify, objx and yaml; the mock now lives in logger/loggertest, which only test files import, and coverage is measured across packages so its callers count. Tests using logger.Mock or logger.NewMock switch to loggertest.Mock and loggertest.NewMock.