update celements2web on-disk pages to 7.0#547
Conversation
fpichler
changed the title
There was a problem hiding this comment.
When we started adding xml-files to disk I had to separate all the files into the projects they belong to: Blog in celements-blog/blog-web, UserAdmin in celements-features/celements-user-manager-web, etc.
You have now added all those pages again to celements-webapp. Either delete the old ones in the different projects or move the current ones where they belong. Maybe also find a way to document the decision for the future.
|
I think we should instead separate the XApp xar bundles into one per web-module, so we can consistently export them from db to disk. |
There was a problem hiding this comment.
There are still a few new files (mostly Templates and Pagetypes). They really seem to be new, I couldn't find them on disk. I commented one that might belong somewhere else. Please check them for:
- correct project?
- still needed? (Might we have deleted them on disk?)
I found quite a few files that look newer on disk as well. So, there might have been mistakes happening with deploying Celements 7 and the xml-files we edited.
| $!jsService.includeExtJsFile($extJsParam.setJsFile(':js/scriptaculous/scriptaculous.js'))## | ||
| $!jsService.includeExtJsFile($extJsParam.setJsFile(':js/xwiki/accordion/accordion.js'))## | ||
| $xwiki.jsfx.use('js/scriptaculous/scriptaculous.js') | ||
| $xwiki.jsfx.use('js/xwiki/accordion/accordion.js') |
There was a problem hiding this comment.
This change looks weird. Isn't the deleted code supposed to be newer?
| $xwiki.jsfx.use("js/xwiki/accordion/accordion.js") | ||
| $xwiki.jsfx.use("js/xwiki/panelwizard/Drag.js") | ||
| $xwiki.jsfx.use("js/xwiki/panelwizard/ieemu.js") | ||
| $xwiki.jsfx.use("js/xwiki/panelwizard/toolTip.js") |
There was a problem hiding this comment.
same here: deleted code should be newer?
| $!jsService.includeExtJsFile($extJsParam.setJsFile(':js/scriptaculous/scriptaculous.js'))## | ||
| $!jsService.includeExtJsFile($extJsParam.setJsFile(':js/xwiki/accordion/accordion.js'))## | ||
| $xwiki.jsfx.use("js/scriptaculous/scriptaculous.js") | ||
| $xwiki.jsfx.use("js/xwiki/accordion/accordion.js") |
| $!jsService.includeExtJsFile($extJsParam.setJsFile(':js/scriptaculous/scriptaculous.js'))## | ||
| $!jsService.includeExtJsFile($extJsParam.setJsFile(':js/xwiki/accordion/accordion.js'))## | ||
| $xwiki.jsfx.use("js/scriptaculous/scriptaculous.js") | ||
| $xwiki.jsfx.use("js/xwiki/accordion/accordion.js") |
| ## Deprecated !!! please use the following parseTemplate line instead! | ||
| ## #parse("celTemplates/ObjectEdit.vm") | ||
| $services.deprecated.logVelocityScript('celements2web:Templates.ObjectEdit.vm') | ||
| $celementsweb.logDeprecatedVelocityScript('celements2web:Templates.ObjectEdit.vm') |
There was a problem hiding this comment.
and again: deleted code is newer
There was a problem hiding this comment.
Does this belong to celements-web? Or rather usermanager-web?
3 participants
Summary
Updates the on-disk
celements2webpages undercelements-webapp/src/main/webapp/docs/celements2web/to the release version7.0from the Maven repository (https://maven.celements.ch/releases/celements-apps/celements2web-7.0.xar).Changes
celements2web/directory with the extracted pages from the7.0.xarrelease package.Celements2/CelementsContextMenu/PageTypes/Panels/SimpleLayout/Templates/XApp/XWiki/BlogTemplates/CalTemplates/TableHeader/TableRow/UserAdmin/UserAdminEdit/UserAdminForm/UserAdminSearch/package.xml(package metadata file)