Skip to content

Jenkinsfile.release#548

Open
msladek wants to merge 1 commit into
devfrom
INFRA-471
Open

Jenkinsfile.release#548
msladek wants to merge 1 commit into
devfrom
INFRA-471

Conversation

@msladek

@msladek msladek commented Jul 6, 2026

Copy link
Copy Markdown
Member

@msladek msladek requested a review from fpichler July 6, 2026 21:47

@fpichler fpichler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest content looks consistent with the release pipeline contract, but I see one security/design issue that affects this PR together with server-tools PR 83.

Jenkinsfile.release passes arbitrary manifest.image and manifest.modules values from this repository into the trusted shared-library releasePipeline. That shared library then reads
Jenkins job SCM metadata/credentials from those module job names and triggers the image job. Anyone who can change this Jenkinsfile can therefore potentially point the release pipeline at
unrelated Jenkins jobs, depending on Jenkins permissions and branch trust settings.

Please add product-scoped allowlisting/validation in the shared library before using these values, or move the release manifests back into trusted shared-library code. The webapp Jenkinsfile
should ideally only select a fixed product, not define arbitrary Jenkins job names.

@fpichler fpichler assigned msladek and unassigned fpichler Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants