Fix build warning for unused variable and mismatched tags. (#13)

* Fix build warnning for unused variable and mismatched tags

* Fix build warning and format code style

Author: zyfjeff

.gitignore

@@ -20,3 +20,10 @@ bin
 
 # Other
 TAGS
+
+# Bazel
+bazel-bin
+bazel-genfiles
+bazel-opencensus-cpp
+bazel-out
+bazel-testlogs

opencensus/stats/examples/exporter_example.cc

@@ -21,16 +21,6 @@
 #include "gtest/gtest.h"
 #include "opencensus/stats/stats.h"
 
-namespace opencensus {
-namespace stats {
-
-struct StatsExporterTest {
-  static constexpr auto& ExportForTesting = StatsExporter::ExportForTesting;
-};
-
-}  // namespace stats
-}  // namespace opencensus
-
 namespace opencensus_examples {
 namespace {
 

opencensus/trace/internal/local_span_store_test.cc

@@ -22,7 +22,8 @@
 namespace opencensus {
 namespace trace {
 
-struct SpanTestPeer {
+class SpanTestPeer {
+ public:
   static void End(absl::Duration latency, Span* span) {
     // Set latency.
     span->span_impl_for_test()->EndWithLatencyForTesting(latency);
@@ -32,7 +33,8 @@ struct SpanTestPeer {
 };
 
 namespace exporter {
-struct LocalSpanStoreImplTestPeer {
+class LocalSpanStoreImplTestPeer {
+ public:
   static void ClearForTesting() {
     LocalSpanStoreImpl::Get()->ClearForTesting();
   }

opencensus/trace/internal/running_span_store_test.cc

@@ -19,6 +19,7 @@
 #include <unordered_map>
 #include <vector>
 
+#include "absl/base/attributes.h"
 #include "absl/memory/memory.h"
 #include "gtest/gtest.h"
 #include "opencensus/trace/exporter/attribute_value.h"
@@ -37,14 +38,16 @@
 namespace opencensus {
 namespace trace {
 
-struct SpanTestPeer {
+class SpanTestPeer {
+ public:
   static void SetSampled(TraceOptions* opts, bool is_sampled) {
     opts->SetSampled(is_sampled);
   }
 };
 
 namespace exporter {
-struct RunningSpanStoreImplTestPeer {
+class RunningSpanStoreImplTestPeer {
+ public:
   static void ClearForTesting() {
     RunningSpanStoreImpl::Get()->ClearForTesting();
   }
@@ -53,23 +56,20 @@ struct RunningSpanStoreImplTestPeer {
 namespace {
 constexpr uint8_t trace_id[] = {1, 2,  3,  4,  5,  6,  7,  8,
                                 9, 10, 11, 12, 13, 14, 15, 16};
-constexpr uint8_t span_id1[] = {1, 0, 0, 0, 0, 0, 0, 11};
-constexpr uint8_t span_id2[] = {2, 0, 0, 0, 0, 0, 0, 22};
-constexpr uint8_t span_id3[] = {3, 0, 0, 0, 0, 0, 0, 33};
+constexpr uint8_t span_id[] = {2, 0, 0, 0, 0, 0, 0, 22};
 
 TEST(RunningSpanStoreTest, ForceSamplingViaStartSpanOptions) {
   // Parent isn't sampled, child is.
   // Child Span with forced sampling.
-  SpanContext parent_ctx2{TraceId(trace_id), SpanId(span_id2)};
+  SpanContext parent_ctx{TraceId(trace_id), SpanId(span_id)};
   AlwaysSampler sampler;
   RunningSpanStoreImplTestPeer::ClearForTesting();
-  auto span2 =
-      Span::StartSpanWithRemoteParent("Span2", parent_ctx2, {&sampler});
-  EXPECT_TRUE(span2.IsSampled());
+  auto span = Span::StartSpanWithRemoteParent("Span", parent_ctx, {&sampler});
+  EXPECT_TRUE(span.IsSampled());
   EXPECT_EQ(1, RunningSpanStore::GetRunningSpans({"", 1}).size());
   EXPECT_EQ(0, RunningSpanStore::GetRunningSpans({"", 0}).size())
       << "Hit max_spans_to_return.";
-  span2.End();
+  span.End();
   EXPECT_EQ(0, RunningSpanStore::GetRunningSpans({"", 1}).size());
 }
 

opencensus/trace/internal/span.cc

@@ -61,7 +61,8 @@ TraceId GenerateRandomTraceId() {
 
 }  // namespace
 
-struct SpanGenerator {
+class SpanGenerator {
+ public:
   static Span Generate(absl::string_view name, const SpanContext* parent_ctx,
                        bool has_remote_parent,
                        const StartSpanOptions& options) {

opencensus/trace/internal/span_options_test.cc

@@ -32,7 +32,8 @@ namespace opencensus {
 namespace trace {
 
 // Helper class to peer into SpanImpl implementation details.
-struct SpanTestPeer {
+class SpanTestPeer {
+ public:
   static exporter::Status GetStatus(Span* span) {
     // This is a hack so that we don't have to add a status() accessor to the
     // public API.

opencensus/trace/internal/span_test.cc

@@ -28,7 +28,8 @@
 namespace opencensus {
 namespace trace {
 
-struct SpanTestPeer {
+class SpanTestPeer {
+ public:
   static SpanId GetParentSpanId(Span* span) {
     return span->span_impl_for_test()->parent_span_id();
   }

opencensus/trace/internal/trace_options_test.cc

@@ -19,7 +19,8 @@
 namespace opencensus {
 namespace trace {
 
-struct SpanTestPeer {
+class SpanTestPeer {
+ public:
   static void SetSampled(TraceOptions* opts, bool is_sampled) {
     opts->SetSampled(is_sampled);
   }