This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Quickstart/Node.js Metrics: Add Node.js Metrics Codelab#513
Open
PikBot wants to merge 1 commit intocensus-instrumentation:masterfrom
Open
Quickstart/Node.js Metrics: Add Node.js Metrics Codelab#513PikBot wants to merge 1 commit intocensus-instrumentation:masterfrom
PikBot wants to merge 1 commit intocensus-instrumentation:masterfrom
Conversation
mayurkale22
reviewed
Dec 27, 2018
| AggregationType.COUNT, | ||
| [methodTagKey], | ||
| "The number of lines from standard input" | ||
| ) |
| // Bucket Boudaries: | ||
| // [>=0B, >=5B, >=10B, >=15B, >=20B, >=40B, >=60B, >=80, >=100B, >=200B, >=400, >=600, >=800, >=1000] | ||
| [0, 5, 10, 15, 20, 40, 60, 80, 100, 200, 400, 600, 800, 1000] | ||
| ) |
Member
There was a problem hiding this comment.
Same here, Semicolon (;) is missing.
| const stats = new Stats(); | ||
|
|
||
| // Add your project id to the Stackdriver options | ||
| const exporter = new StackdriverStatsExporter({projectId: "your-project-id"}); |
Member
There was a problem hiding this comment.
I think it is worth to mention below lines here,
// Exporters use Application Default Credentials to authenticate.
// See https://developers.google.com/identity/protocols/application-default-credentials
// for more details.
WDYT?
Contributor
Author
There was a problem hiding this comment.
Yes, that would be useful for the reader.
| stats.record({ | ||
| measure: mLatencyMs, | ||
| tags, | ||
| value: (new Date()) - startTime.getTime() |
Member
There was a problem hiding this comment.
This should be value: new Date().getTime() - startTime.getTime() . Also, startTime variable is not defined anywhere in the code.
Member
|
Following suit with #512, we should use open source exporter (Prometheus) for Node.js codelabs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codelab for Node.js metrics quickstart
@odeke-em please review!