[players] Make preview height independent of viewport width#2057
Merged
Conversation
The preview player height was gated on `windowWidth > 1300`, which collapsed it to 200px on OS-scaled / high-DPI displays whose CSS viewport is under 1300px (a 1920x1200 panel at 150% scaling reports 1280px). Enlarging the preview then did almost nothing, while the same content on a 1920x1080 screen at 100% worked — the "resizing inconsistent across screen sizes" of cgwire#2056. Height should follow available vertical space, not width: drop the width gate and the now-unused windowWidth ref. The windowHeight > 800 threshold and the compact light-mode (200px) are unchanged. Fix cgwire#2056 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
windowWidth > 1300, collapsing it to 200px on OS-scaled / high-DPI displays whose CSS viewport is under 1300px (e.g. a 1920x1200 panel at 150% scaling reports 1280px). Enlarging the preview then did almost nothing, while the same content on a 1920x1080 screen at 100% worked — the "resizing inconsistent across screen sizes" of Preview Window Resizing Inconsistent Across Screen Sizes #2056.Solutions
windowWidthref): the preview height follows available vertical space, not width. ThewindowHeight > 800threshold and the compact light-mode (200px) are unchanged.Fix #2056