[players] Reset pan/zoom and load sub-preview annotations on preview switch#2058
Merged
frankrousseau merged 1 commit intoJun 17, 2026
Merged
Conversation
…switch Two bugs when switching the displayed preview in the playlist players: - Pan/zoom was not reset for annotations on entity / sub-preview / version switch. resetPanZoom() resets the viewer silently (PictureViewer.setPanZoom runs with silent=true and emits no panzoom-changed), so panzoomTransform — which drives AnnotationCanvas — kept the previous transform and annotations stayed offset/zoomed. Reset panzoomTransform alongside resetPanZoom in the currentPreviewIndex and playingEntityIndex watchers and in changePreviewFile (version switch), and add a currentPreview.id reset watcher in SharedPlaylistPlayer. - Sub-previews no longer loaded their annotations: since annotations were removed from the playlist payload, the on-demand loader only handled the entity's main preview. Generalise it (ensureCurrentPreviewAnnotations) to load the current preview's annotations whether it is the main or a sub-preview. (Guest player keeps annotations inline, so it is unaffected.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
panzoomTransform, which drivesAnnotationCanvas.resetPanZoom()resets the viewer silently (PictureViewer.setPanZoomruns withsilent=true, emitting nopanzoom-changed), so the annotation transform kept the previous pan/zoom and annotations were left offset/zoomed.Solutions
panzoomTransformalongsideresetPanZoom()in thecurrentPreviewIndexandplayingEntityIndexwatchers and inchangePreviewFile(version switch); add acurrentPreview.idreset watcher inSharedPlaylistPlayer.ensureCurrentPreviewAnnotations) to load the current preview's annotations whether it is the main preview or a sub-preview. The guest player keeps annotations inline, so it is unaffected by the regression.