Remove custom rabbitMQ container in favor of upstream image#437
Open
MoralCode wants to merge 5 commits into
Open
Remove custom rabbitMQ container in favor of upstream image#437MoralCode wants to merge 5 commits into
MoralCode wants to merge 5 commits into
Conversation
…efault Assisted-by: Sonnet 4.6 Medium via Cursor Agent Window Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…env vars Assisted-by: Sonnet 4.6 Medium via Cursor Agent Window Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
… job Signed-off-by: Adrian Edwards <adredwar@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the need for a custom-built RabbitMQ container for running CollectOSS and instead relies on the container image published upstream by RabbitMQ.
This eliminates the security problem with the credentials that the container build was baking into the image.
This PR fixes #278
This PR supersedes #397
Notes for Reviewers
Signed commits
Generative AI disclosure
Please select one option:
If AI tools were used, please provide details below:
- What tools were used? Sonnet 4.6 Medium via Cursor
- How were these tools used? Initial plan of work and feasibility assessment, including evaluating the usefulness of existing configuration items.
- Did you review these outputs before submitting this PR? every line of code suggested (in ask mode) was read before implementing it, and the code changes were tested to ensure that they do, in fact, allow CollectOSS to run normally