Repository navigation
Retry checkpoint callbacks durably - #306
Merged
Merged
Conversation
lukevalenta
requested review from
a team,
bwesterb,
cjpatton,
lbaquerofierro and
mendess
as code owners
October 16, 2026 15:09
lbaquerofierro
left a comment
Contributor
There was a problem hiding this comment.
The description says CT keeps its existing behavior, but CT also changes here: a failed checkpoint upload to R2 is now fatal, and load() re-uploads the checkpoint. Maybe add a line about that to the description, with the reason?
lbaquerofierro
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A sequencer commits a checkpoint before calling its application callback. If that callback fails after the checkpoint is durable, the failure is logged but its input is lost. MTC landmark publication is such a callback: losing it leaves a checkpoint that cannot later acquire the landmark-dependent objects expected by clients.
This change persists the callback input before invoking a callback configured for durable delivery. It clears that record only after success, and retries it before a subsequent checkpoint is sequenced. Durable callback delivery is idempotent because the callback may run more than once after a callback or cleanup failure.
When a durable callback retry keeps failing, the sequencer skips new sequencing and increments
checkpoint_callback_retry_failures_totalso the condition can be alerted on.CT keeps its best-effort callback delivery and does not persist callback inputs. It does, however, adopt the fatal checkpoint-upload handling and checkpoint re-upload recovery needed to keep its existing state consistent after storage failures.
Compatibility
This changes Durable Object state and callback delivery only. It does not change checkpoint text, signed-note signatures, tile paths, entry bundles, or HTTP responses. It remains wire-compatible with the current versionless
c2sp.org/tlog-tilesspecification andc2sp.org/tlog-checkpoint@v1.1.0.