Repository navigation
fix: upload binary multipart arrays as files - #501
Merged
Merged
Conversation
commit: |
Contributor
|
LGTM! |
![clanky-the-clanker[bot]](https://avatars.githubusercontent.com/in/5306670?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Approved — No issues found in the generator change, the regenerated command, the docs or the changeset.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
🚀 Release: ✅ LGTM
Risk: Low. Patch changeset is appropriate for this fix.
🔒 Security: ✅ LGTM
No issues found.
📖 AGENTS.md: ✅ LGTM
No issues found.
📋 Code Quality: ✅ LGTM
No issues found.
⚡ Performance: ✅ LGTM
No issues found.
📝 Documentation: ✅ LGTM
No issues found.
Reviewed commit: dab08522
Contributor
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 281.3 ms | 4.3 ms | 276.0 ms | 294.7 ms |
| base | 279.9 ms | 3.5 ms | 275.5 ms | 288.7 ms |
Δ (PR vs base): ↑ +1.3 ms (+0.5%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
edmundhung
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf ai to-markdownsent--fileunder the wrong multipart field and treated--filesas text. Recognize binary multipart arrays in the generator so single uploads usefilesand--files @first.html @second.pdf(or repeated flags) sends separate file parts, preserving each file's bytes and filename.Regenerate the command and metadata, document the array flag, and add a patch changeset. Regression tests cover single and multiple uploads, binary bytes, filenames, invalid tokens, dry runs, and referenced or nullable schemas.
Fixes #463.
Validation:
pnpm check— passed.pnpm --filter cf test— 2,402 passed, 7 skipped.