Fix: client secret re-encoding#3962
Closed
jochenehret wants to merge 1 commit into
Closed
Conversation
…nts on startup
Spring Security 7's BCryptPasswordEncoder now extends AbstractValidatingPasswordEncoder,
which returns false from matches() when rawPassword is empty. ClientAdminBootstrap calls
nonCachingPasswordEncoder.matches("", storedHash) to check whether a client's secret has
changed; for clients with an empty secret (e.g. the CF CLI `cf` client) this now always
returns false, causing a new BCrypt hash to be written to the DB on every UAA startup.
jochenehret
changed the title
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
Member
|
I am also out of Copilot quota |
Member
|
FYI. |
Member
|
We are going with #3965 |
github-project-automation
Bot
moved this from Inbox
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spring Security 7's BCryptPasswordEncoder now extends AbstractValidatingPasswordEncoder, which returns false from matches() when rawPassword is empty. ClientAdminBootstrap calls nonCachingPasswordEncoder.matches("", storedHash) to check whether a client's secret has changed; for clients with an empty secret (e.g. the CF CLI
cfclient) this now always returns false, causing a new BCrypt hash to be written to the DB on every UAA startup.Note: This PR has been AI-generated. It resolves the issue we currently have with the BOSH disaster-recovery-acceptance-tests ("failed to verify token with uaa"):
https://concourse.wg-ard.ci.cloudfoundry.org/teams/main/pipelines/cf-deployment/jobs/bbr-run-drats/builds/2453
I cannot judge however if the fix is conceptually correct. Please review carefully.