Repository navigation
adding new background color utilities and a light text utility - #2580
Conversation
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
spaceninja
left a comment
spaceninja
left a comment
There was a problem hiding this comment.
The existing code works, so I'm approving it, but I've left some questions that I'd love to see addressed. Holler at me if you need a followup review! 😁
|
|
||
| .u-bg-none { | ||
| background: transparent !important; | ||
| color: inherit !important; |
There was a problem hiding this comment.
I'm surprised to see a background color utility set the text color. Can you help me understand why we need this? Does it interact well with u-text-light? Would it be better served as a separate u-text-inherit utility?
There was a problem hiding this comment.
I removed the color declaration here and figured out how to add additional u-text-light and u-text-dark classes to the examples.
| .u-text-light { | ||
| color: color.$base-white !important; | ||
| } |
There was a problem hiding this comment.
Should we add u-text-dark at the same time? Should it use the existing $text-light Sass variable?
There was a problem hiding this comment.
Makes sense, I added a u-text-dark as well!
|
@spaceninja Since you approved this, I'm going to merge it in, but just wanted to note that I have addressed the feedback you provided! |
|
Oh wait, I think you actually do need to re-approve @spaceninja probably because I made changes? |
2 participants
Overview
I'm working on modifying our article card pattern to work well without a cover image. Adding these utilities will support that effort.
Screenshots