Skip to content

feat(ci): consolidate PR checks and add /e2e command runner#1994

Open
abhijith-darshan wants to merge 21 commits into
mainfrom
feat/workflow_enhancement
Open

feat(ci): consolidate PR checks and add /e2e command runner#1994
abhijith-darshan wants to merge 21 commits into
mainfrom
feat/workflow_enhancement

Conversation

@abhijith-darshan
Copy link
Copy Markdown
Contributor

@abhijith-darshan abhijith-darshan commented May 19, 2026

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #1771

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@abhijith-darshan abhijith-darshan requested a review from a team as a code owner May 19, 2026 00:15
Copilot AI review requested due to automatic review settings May 19, 2026 00:15
@abhijith-darshan abhijith-darshan requested a review from a team as a code owner May 19, 2026 00:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@cloudoperators cloudoperators deleted a comment from github-actions Bot May 19, 2026
@abhijith-darshan abhijith-darshan force-pushed the feat/workflow_enhancement branch from 3a10a8f to a9e1b82 Compare May 19, 2026 00:31
@abhijith-darshan abhijith-darshan changed the title ci(workflows): consolidate PR checks and add /e2e command runner feat(ci): consolidate PR checks and add /e2e command runner May 19, 2026
@abhijith-darshan abhijith-darshan requested a review from a team as a code owner May 19, 2026 00:35
@cloudoperators cloudoperators deleted a comment from github-actions Bot May 19, 2026
@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

2 similar comments
@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

@abhijith-darshan abhijith-darshan force-pushed the feat/workflow_enhancement branch from 2a483d1 to f0ff092 Compare May 25, 2026 20:16
@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

3 similar comments
@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

@abhijith-darshan abhijith-darshan force-pushed the feat/workflow_enhancement branch from 453ae14 to 11c4705 Compare May 25, 2026 21:07
@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

@abhijith-darshan abhijith-darshan force-pushed the feat/workflow_enhancement branch from 11c4705 to 991d73d Compare May 25, 2026 23:02
@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

@abhijith-darshan abhijith-darshan force-pushed the feat/workflow_enhancement branch from 991d73d to 8ae2a7f Compare May 26, 2026 13:04
@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e all

@abhijith-darshan abhijith-darshan force-pushed the feat/workflow_enhancement branch from 8ae2a7f to 8fb3840 Compare May 29, 2026 11:22
@github-actions
Copy link
Copy Markdown

E2E Info

Detected E2E Suites
/e2e plugin

Comment /e2e all to run all suites.

@abhijith-darshan
Copy link
Copy Markdown
Contributor Author

/e2e plugin

IvoGoman
IvoGoman previously approved these changes May 29, 2026
Refines test workflows for renovate automerge by collapsing the
fragmented PR pipeline into three required jobs (lint, test, build)
and gating e2e behind explicit `/e2e` PR comments.

- ci-pr.yaml: single PR workflow with paths-filter-driven lint-go,
  lint-generated, lint-charts, lint-license, lint-reuse, test, build;
  checksOK aggregator treats success+skipped as pass for stable
  required-status semantics.
- ci-e2e-info.yaml: posts a per-PR info comment listing relevant
  suites with `/e2e <suite>` examples; auto-comments `/e2e all` on
  renovate PRs so the automerge chain runs unattended.
- ci-e2e-runner.yaml: issue_comment-triggered matrix runner; supports
  `/e2e all`, `/e2e skip`, and explicit suite lists; posts per-suite
  and aggregate `e2eOK` commit statuses on the PR head SHA.
- paths-filters-{ci,e2e}.yaml: split path rules into editable config
  files so suite scoping changes don't require workflow edits.
- ci-e2e-test-nightly.yaml: bump admin cluster to v1.34.3.
- Drop superseded workflows: ci-e2e-test, unit-tests, pr-docker-build,
  helm-lint, kustomize-lint, check-changes-crd-api, license, ci-reuse.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
- ci-e2e-info.yaml: auto-comment `/e2e skip` when paths-filter detects
  no relevant suites; auto-comment `/e2e all` (or `/e2e skip`) on
  renovate PRs so the automerge chain runs without human input
- info comment: drop the "no matches" branch (handled by auto-skip),
  drop hardcoded suite list, flatten nested <details> into a single
  collapsible with copyable `/e2e <suite>` blocks per matched suite

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
…comment

- ci-pr.yaml: lint-license now grants contents:write at job level so
  the called shared workflow's apply-license-header job (gated by
  apply_header=false at runtime) passes static permission validation
- ci-e2e-info.yaml: flatten the info comment into a header line, one
  collapsible per matched suite, and a single worked example; drop
  the redundant nested details block

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
- ci-e2e-info.yaml: rename the github-script step to "E2E Info" so the
  Actions UI surfaces something meaningful
- delete any previous bot info comment and always create a fresh one,
  so the comment can't get buried in long review threads (it'll show
  up at the bottom on every push)

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Collapse detected suites into a single expandable block and tag
ci-pr.yaml as CC0-1.0 so the unused-license check passes.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Render the detected suites inside the collapsible as a code block of
/e2e <suite> lines so they can be copied directly into a comment.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Add reactions:write permission to ci-e2e-run.yaml and delete the
old pull_request-triggered ci-e2e-test.yaml — replaced by the
comment-driven ci-e2e-run.yaml.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Use issues:write instead of reactions:write — GitHub reactions API
requires issues=write scope.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Remove the rocket reaction step — it requires issues:write which
the GITHUB_TOKEN cannot be granted from a PR branch workflow.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Updates both ci-e2e-run and ci-e2e-test-nightly to pin
cloudoperators/common/workflows/e2e to the latest main SHA
which includes the new optional ref input.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Posts pending/success/failure commit status for each matrix suite
so the PR checks page shows individual suite results with a spinning
indicator while running, alongside the aggregate e2eOK gate.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
HTML markers prepended to the comment body prevented ci-e2e-run from
triggering since it checks startsWith('/e2e'). Auto-posted comments
now contain only the bare /e2e command.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
@abhijith-darshan abhijith-darshan force-pushed the feat/workflow_enhancement branch from cef6962 to ce721b6 Compare May 29, 2026 12:00
Auto-skip and renovate auto-run jobs now post comments via a GitHub
App token so the comment triggers ci-e2e-run (GITHUB_TOKEN comments
cannot trigger other workflows). Steps are gated on
!github.event.pull_request.head.repo.fork to avoid secret access
failures on forked PRs.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
@cloudoperators cloudoperators deleted a comment from github-actions Bot May 29, 2026
@cloudoperators cloudoperators deleted a comment from github-actions Bot May 29, 2026
Switch from permission-issues to permission-pull-requests for the
GitHub App token used to post auto-skip and renovate e2e comments.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
@cloud-operator-bot
Copy link
Copy Markdown
Contributor

/e2e skip

The bot posts auto-skip and renovate e2e comments via GitHub App token.
Allow it through the collaborator check by matching the actor name
directly.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
@cloud-operator-bot
Copy link
Copy Markdown
Contributor

/e2e skip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] - Refine test workflows for renovate automerge

3 participants