Fix #839: Prefix review-comment commands with "Codev:"#864
Merged
Conversation
Two contributes.commands entries in packages/vscode/package.json were missing the "Codev:" prefix used by every other declared command, making them look like they came from a different extension in the VS Code Feature Contributions tab. - codev.submitReviewComment: "Submit review comment" -> "Codev: Submit Review Comment" - codev.deleteReviewComment: "Delete review comment" -> "Codev: Delete Review Comment" All 40 entries on the Feature Contributions command list now start with "Codev:".
Collaborator
Author
Architect ReviewLow-risk change. Surgical 2-line manifest fix in Verified:
Approved. Please merge. Architect review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two entries in
packages/vscode/package.json#contributes.commandswere missing theCodev:prefix that every other command in the extension uses. On the VS Code Feature Contributions tab they appeared as if they came from a different extension. This PR renames the two titles to match the existing title-cased convention (Codev: Open Builder Terminal,Codev: Approve Gate, …).Fixes #839
Root Cause
codev.submitReviewCommentandcodev.deleteReviewCommentwere declared with titles"Submit review comment"and"Delete review comment". Both are hidden from the Command Palette viamenus.commandPalette { when: false }(they target the comment-thread gutter), but the Feature Contributions tab lists every declared command regardless — exposing the inconsistency.Fix
packages/vscode/package.json:codev.submitReviewComment:"Submit review comment"→"Codev: Submit Review Comment"codev.deleteReviewComment:"Delete review comment"→"Codev: Delete Review Comment"Audited all 40
contributes.commandsentries — every entry now starts withCodev:. No other files reference these title strings (commands are wired up bycommandid, not title).Test Plan
pnpm build)contributes.commandsentry — all 40 nowCodev:-prefixed