Skip to content

refactor: reduce PHPStan child return type baseline#10165

Open
memleakd wants to merge 1 commit intocodeigniter4:developfrom
memleakd:refactor/phpstan-child-return-fluent-docs
Open

refactor: reduce PHPStan child return type baseline#10165
memleakd wants to merge 1 commit intocodeigniter4:developfrom
memleakd:refactor/phpstan-child-return-fluent-docs

Conversation

@memleakd
Copy link
Copy Markdown
Contributor

@memleakd memleakd commented May 6, 2026

Description
Refines PHPDoc return types so they are covariant with parent/interface contracts and better match the current implementations.

This reduces method.childReturnType PHPStan baseline entries from 28 to 2. The remaining entries are UploadedFile::move() and OutgoingRequest::getUri(), which are real API contract conflicts and should be handled separately.

Related to #6310.

Verification:

  • composer phpstan:check
  • git diff --check

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@memleakd memleakd force-pushed the refactor/phpstan-child-return-fluent-docs branch from 98eaf51 to 90a6036 Compare May 6, 2026 21:21
Copy link
Copy Markdown
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending rebase.

Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
@memleakd memleakd force-pushed the refactor/phpstan-child-return-fluent-docs branch from 90a6036 to d99ccad Compare May 9, 2026 17:52
@memleakd
Copy link
Copy Markdown
Contributor Author

memleakd commented May 9, 2026

Pending rebase.

Rebased, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants