v0.1.29 feat: intent capture via set_intent MCP tool#28
Conversation
…ering - New set_intent MCP tool appends type=intent events to session.jsonl - AgentdiffMetadata gains intent_type: Option<String> field - report.rs renders [type] intent in Review Context and trace details table - context_json_report includes intent_type in JSON output - AGENTS.md managed block instructs agents to call set_intent before committing - 6 new tests (tools/list, set_intent happy path, empty description rejection)
…inalize - read_intent_events() scans session.jsonl for type=intent events since last commit - Intent priority: agent-stated event (session-id matched) > pending context > none - intent_type propagated through pending_ledger.json to finalize-ledger.py - 2 new tests: write_agent_trace persists intent_type and full structured metadata
- Fix byte-boundary panic: slice description by chars not bytes (Rust) - Add server-side intent_type enum validation in set_intent() (Rust) - Skip session-id matching when session_id is 'unknown' to prevent cross-session bleed - Separate read-loop from os.replace in remove_consumed_intents to avoid swallowing rename errors
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AgentDiff ReportSummary
Review Context
Files To Review First
Trace details
|
Greptile SummaryThis PR adds intent capture to the AgentDiff commit flow. The main changes are:
Confidence Score: 3/5This should be fixed before merging because the intent flow can persist the wrong data.
Important Files Changed
Sequence DiagramsequenceDiagram
participant Agent
participant MCP as agentdiff-mcp
participant Session as session.jsonl
participant Prepare as prepare-ledger.py
participant Pending as pending-ledger.json
participant Finalize as finalize-ledger.py
participant Trace as AgentTrace
Agent->>MCP: set_intent(description, intent_type)
MCP->>Session: "append type=intent event"
Prepare->>Session: read intent events
Prepare->>Pending: write intent metadata
Finalize->>Pending: read pending ledger
Finalize->>Trace: persist intent metadata
Finalize->>Session: prune intent events
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| match set_intent(&args, default_cwd) { | ||
| Ok(out_path) => response_ok( | ||
| rid, | ||
| json!({ | ||
| "content": [{ | ||
| "type":"text", | ||
| "text": format!("intent recorded in {}", out_path.display()) | ||
| }], | ||
| "structuredContent": { | ||
| "status":"recorded", | ||
| "path": out_path.display().to_string() | ||
| } | ||
| }), | ||
| ), | ||
| Err(err) => response_error(rid, -32000, format!("{err:#}")), |
There was a problem hiding this comment.
set_intent branch maps every set_intent() error to -32000. That includes the new enum validation for intent_type, so a caller that sends an unknown type receives an internal server error instead of the invalid-params error expected for bad tool input. MCP clients can then handle a user input problem as a server failure.
| try: | ||
| event = json.loads(line) | ||
| if isinstance(event, dict) and event.get("type") == "intent": | ||
| continue |
There was a problem hiding this comment.
type=intent line in session.jsonl, not just the intent that was attached to the commit being finalized. If an agent records the next commit's intent while this post-commit hook is still running, that new event is deleted before the next pre-commit can read it, so the next trace silently loses its intent.
| if not best_intent: | ||
| best_intent = intent_events[-1] |
There was a problem hiding this comment.
session_id but no intent event matches it, this falls back to the latest intent from any session. A commit attributed to sess-A can therefore receive an intent recorded by sess-B as long as that event is newer than HEAD, which is another cross-session bleed case.
| if not best_intent: | |
| best_intent = intent_events[-1] | |
| if not best_intent and (not session_id or session_id == "unknown"): | |
| best_intent = intent_events[-1] |
| let mut file = fs::OpenOptions::new() | ||
| .create(true) | ||
| .append(true) | ||
| .open(&session_path) | ||
| .with_context(|| format!("opening {}", session_path.display()))?; | ||
| writeln!(file, "{}", event.to_string()) | ||
| .with_context(|| format!("writing to {}", session_path.display()))?; |
There was a problem hiding this comment.
set_intent appends directly to session.jsonl without taking a lock. Multiple MCP servers or capture hooks can write at the same time, and finalize-ledger.py can rewrite the same file while this append happens. That can corrupt JSONL or drop a valid intent, and prepare-ledger.py will silently skip malformed lines.
| "prompt": args.prompt or str(payload.get("prompt") or ""), | ||
| "files_read": parse_json_array(args.files_read) or payload.get("files_read") or [], | ||
| "intent": args.intent or str(payload.get("intent") or ""), | ||
| "intent_type": args.intent_type or str(payload.get("intent_type") or ""), |
There was a problem hiding this comment.
choices check only applies to the CLI flag. This line still accepts intent_type from stdin JSON without validating it, and that value can be persisted by prepare/finalize into the trace. A caller piping {"intent_type":"other"} through the documented stdin path bypasses the new allowlist.
1 participant
Summary
Intent capture — agents now record why they made changes, not just what they changed. Intent flows from the MCP tool call at edit time through to signed traces and PR comments.
New capability
set_intentMCP tool inagentdiff-mcp: agents call this before committing with a 1-2 sentence description of the change goal + anintent_typeenum (bugfix/feature/refactor/test/docs/security/performance/config/dependency). Written astype=intentevents tosession.jsonl.AgentdiffMetadatagainsintent_type: Option<String>field, persisted throughprepare-ledger.py→finalize-ledger.py→ signedAgentTrace.agentdiff report --format markdown --contextrenders[type] intentin the Review Context block and a Type column in the trace details table. JSON report includesintent_type.set_intentbefore committing.Bug fixes (this branch)
type=intentevents fromsession.jsonlafter finalize — prevents stale intent from the previous commit bleeding into the next one when two commits land in the same second.--intent-typeinrecord-context.pynow validated via argparsechoices=.description[..500]now slices by char boundary, not bytes — prevented panic on any non-ASCII description ≥ 500 bytes.intent_typeenum validation in Rustset_intent()— returns MCP error-32602for unknown values, so the MCP schema enforcement is no longer advisory-only.session_id = "unknown"to prevent cross-session intent bleed.os.replacefrom the read-loop inremove_consumed_intentsso a rename failure no longer silently leaves a.tmpghost file and stale intent events.End-to-end flow
Pre-Landing Review
10 findings reviewed. 4 HIGH/MEDIUM issues fixed before push:
Remaining noted items (non-blocking):
head_commit_tsreturns 0 on fresh/detached repo — all historical events pass filter (correct for first commit; edge case on detached HEAD)read_intent_eventsandremove_consumed_intentsin isolation — covered by integration path viatest_write_agent_trace_persists_intent_typeintent_typeinfinalize-ledger.pywritten to trace without allowlist check (upstream is now validated at MCP layer)Test Coverage
All 68 tests pass (47 Rust + 21 Python). New tests added:
set_intent_writes_to_session_jsonl— verifies MCP tool writes correct event fieldsset_intent_requires_description— empty description returns MCP errortools_list_includes_both_tools— both tools appear in tools/list responsetest_write_agent_trace_persists_intent_type— finalize persists intent_type to tracetest_write_agent_trace_persists_structured_context_metadata— full metadata roundtripmarkdown_trace_report_includes_review_context— report renders [type] intent formatcontext_json_report_includes_trace_metadata— JSON report includes intent_typeTest plan
[bugfix] Fix stale intent bleed...🤖 Generated with Claude Code