docs: correct Node engines floor to >=20.0.0 in CLAUDE.md#880
Open
Dashsoap wants to merge 1 commit into
Open
Conversation
CLAUDE.md stated `>=18.0.0 <25.0.0`, but the actual supported floor is
Node 20. Three sources agree on 20, not 18:
- package.json "engines": ">=20.0.0 <25.0.0"
- src/bin/node-version-check.ts: MIN_NODE_MAJOR = 20 (hard-enforced
at CLI bootstrap, with a 'requires Node.js 20 or newer' banner)
- the buildNodeTooOldBanner text shown below that floor
Align the doc with the enforced floor so the LLM-readable guidance
doesn't claim Node 18 works when the CLI hard-exits below 20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CLAUDE.md '## Build, Test, Run' section says:
The actual supported floor is Node 20, not 18. This one-line doc fix aligns it with the code.
Why
Three sources of truth all say 20, only this doc line says 18:
"engines": { "node": ">=20.0.0 <25.0.0" }export const MIN_NODE_MAJOR = 20;, hard-enforced at CLI bootstrap (not just an npm warning). Its own JSDoc: "Lowest supported Node.js major version. Matches theenginesfloor in package.json."So the CLI hard-exits on Node 18, but the LLM-readable architecture doc tells agents 18 is fine. Diff:
Docs-only, no code change.