DRYD-2073: Object Record > All Profiles > Add Home Location#541
Open
spirosdi wants to merge 3 commits into
Open
DRYD-2073: Object Record > All Profiles > Add Home Location#541spirosdi wants to merge 3 commits into
spirosdi wants to merge 3 commits into
Conversation
This was referenced Jun 8, 2026
mikejritter
approved these changes
Jun 15, 2026
mikejritter
left a comment
Contributor
There was a problem hiding this comment.
Tested locally and verified objects with
- No home location
- Single home location
- Multiple home locations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
It adds a repeatable
homeLocationGroupListto the collectionobject common schema. So that it is available in advanced search results and it can be displayed alongside the computed current location.Why are we doing this? (with JIRA link)
We need to add a repeating group of
homeLocationandhomeLocationNotefields along thecomputedCurrentLocationfield. We also need to display all the home locations in the advanced search results. https://collectionspace.atlassian.net/browse/DRYD-2073How should this be tested? Do these changes have associated tests?
Please follow the steps in the PR: collectionspace/cspace-ui.js#355
Dependencies for merging? Releasing to production?
The following PRs should be released along:
collectionspace/application#352
collectionspace/cspace-ui.js#355
collectionspace/cspace-ui-plugin-profile-anthro.js#44
collectionspace/cspace-ui-plugin-profile-fcart.js#33
collectionspace/cspace-ui-plugin-profile-lhmc.js#34
collectionspace/cspace-ui-plugin-profile-materials.js#22
collectionspace/cspace-ui-plugin-profile-publicart.js#35
Has the application documentation been updated for these changes?
The changelog has been updated.
Did someone actually run this code to verify it works?
@spirosdi ran it locally
Have any new security vulnerabilities been handled?
no new vulnerabilities introduced