Repository navigation
Conversation
I removed the sentence in `capi/main.go` that said releases build the C library through a `capi` GoReleaser build, since no such build exists. Release artifacts still won't include `libdbc.a`. I didn't add the GoReleaser build. The existing release config builds everything with `CGO_ENABLED=0`, and a `-buildmode=c-archive` build needs cgo plus a C cross-compiler for every OS/architecture pair, which CI doesn't have yet. That needs its own change if you want the library in releases. The package comment still gives the manual `go build` command. The build passes and `go test ./...` passes. Changes: - Removed the comment in `capi/main.go` saying a `capi` build in `.goreleaser.yaml` produces the C archive, since that packaging isn't set up yet
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capi/builds as a Goc-archiveexposing 13 functions: an opaquedbc_clientconfigured with ADBC-style key/value options, and a singledbc_listresult type read withdbc_list_get/dbc_list_info(DBC_FIELD_*ids).libdbc.his generated by cgo fromcapi/exports.go; there is no hand-written header.Stacked on #546.