Skip to content

ci(test): check the Vercel build output - #65

Merged
larbish merged 1 commit into
mainfrom
ci/vercel-output-check
Oct 21, 2026
Merged

larbish merged 1 commit into
mainfrom
ci/vercel-output-check

Conversation

@larbish

@larbish larbish commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Builds the playground with the Vercel preset in a parallel CI job and checks .vercel/output without deploying it.

  • Routing: Build Output API v3, /(.*) → /__fallback last, every header-only route has continue: true (fix(vercel): mark header-only route entries as continue nitrojs/nitro#4651)
  • ISR: resolves sample URLs the way Vercel routes them, asserting each one's TTL (300s, or never for SHA-pinned routes) and that the webhook, assistant, head commit and MCP stay uncached
  • Bypass token: every ISR function carries the same one, so the push webhook can purge pages (CI builds with a placeholder)
  • Server function: Node.js runtime, response streaming for the assistant, a 100 MB budget (54 MB today), content snapshot + manifest bundled with one commit stamp
  • New vercel Vitest project and pnpm test:vercel script

🤖 Generated with Claude Code, reviewed by @larbish before opening.

Summary by CodeRabbit

  • Tests

    • Added comprehensive validation for Vercel build output, including routing, incremental rendering, streaming responses, runtime settings, bundle limits, and embedded assets.
    • Added a dedicated test configuration for Vercel-specific integration coverage.
  • Chores

    • Added automated CI coverage for building and testing the application with the Vercel deployment target.
    • Added a package command for running Vercel integration tests locally.

@coldtea-pr-lens

Copy link
Copy Markdown

Note

The title starts with ci(test):, so PR Lens left this pull request undrawn. Comment @pr-lens draw to draw it

github.comment.notice: false in .github/pr-lens.yml turns this note off

@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
comark-docs-layer Ready Ready Preview Oct 21, 2026 8:49am UTC

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6b500d2f-2596-4d07-b0d0-556777b5ea49
📥 Commits

Reviewing files that changed from the base of the PR and between a160704 and 850821c.

📒 Files selected for processing: 4
  • .github/workflows/ci.yml
  • package.json
  • test/vercel/output.test.ts
  • vitest.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The change adds a Vercel-specific Vitest project and build-output tests. A new CI job builds the Vercel target and runs those tests.

Changes: Vercel output validation

Layer / File(s) Summary
Configure the Vercel test project
vitest.config.ts, package.json
The unit project excludes test/vercel/**. A Node-based Vercel project runs those tests, and test:vercel invokes that project.
Validate Vercel build output
test/vercel/output.test.ts
Adds checks for Build Output API v3 routing, ISR settings, server-function runtime and streaming, bundle size, and embedded asset commit references.
Build and test the Vercel target
.github/workflows/ci.yml
Adds a CI job that installs dependencies, builds with NITRO_PRESET=vercel and a placeholder bypass token, then runs pnpm test:vercel.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: benjamincanac

Merge Risk: ⚪ Minimal · up to 85082

The Vercel validation job is mergeable after normal checks; no confirmed blocking issue remains.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding CI tests for the Vercel build output.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 21, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/comarkdown/comark-docs@65

commit: 850821c

@larbish
larbish merged commit 2a35a14 into main Oct 21, 2026
7 checks passed
@larbish
larbish deleted the ci/vercel-output-check branch October 21, 2026 09:28

This branch was successfully deployed

1 active deployment
Preview — 850821cf Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant