Repository navigation
perf(notifications): drive the toast fall from the frame clock - #427
Merged
Merged
Conversation
OakChaser
force-pushed
the
fix/toast-fall-framerate
branch
from
October 30, 2026 09:13
57c9c76 to
1bb47db
Compare
OakChaser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toast checkmark fall was stepped by a 16ms Slint timer, so it advanced in coarse increments decoupled from the render frame and looked choppier than the rest of the UI. It now derives its progress from animation-tick() in ui/overlays/notifications.slint, with the timer kept only as the 450ms completion signal, so the parabola is sampled once per rendered frame and a reused toast row starts clean.