refactor: replace interface{} with any (Go 1.18+)#211
Closed
MD-Mushfiqur123 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for doing this. What you are doing it part of a (possibly) bigger undertaking -- the ctr of this project needs to be sync'ed again with the codebase of the one from containerd. They also made those changes you are propopsing in your PR here as well. |
| containers.Container | ||
| Spec interface{} `json:"Spec,omitempty"` | ||
| Spec any `json:"Spec,omitempty"` | ||
| }{ |
Contributor
There was a problem hiding this comment.
You commit is missing a Signed-off-by.
Author
|
@stefanberger thanks for the review. You're right that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all occurrences of
interface{}withany(introduced in Go 1.18) for modern Go idiom.Files changed:
cmd/ctr/commands/commands.gocmd/ctr/commands/containers/containers.gocmd/ctr/commands/run/run_unix.gocmd/ctr/commands/run/run_windows.go