Repository navigation
Conversation
Defaulting in parseNetdevices updates a range variable rather than the returned slice. Keep omitted interface names and address prefixes on the parsed devices, so injection receives the intended interface name. Correct the sample's annotation prefix to the one accepted by the plugin and run its parser regressions as part of make test. Signed-off-by: xinjun.jiang <xinjun.jiang@daocloud.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The network device injector discards its default interface name and IP prefix because it updates a copy of each parsed device. Preserve those defaults in the returned slice, and correct the annotation key in the README and sample pod so the example is recognized by the plugin.
Add regression coverage for current and legacy annotation keys, IPv4/IPv6 defaults, explicit values, and the sample pod. Include this plugin's tests in
make test.Validation:
make test, plugin tests with-race,go vet, plugin build, plugin golangci-lint, and codespell passed. Root golangci-lint 2.14 reports the existing deprecatedLinuxMemory.Kernelfield, also reproduced on unmodified upstream. No network interfaces or runtime configuration were changed during validation.AI assistance was used in preparing this contribution.