Repository navigation
Conversation
Signed-off-by: vpatelsj <vpatelsj@gmail.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The probe can exhaust the fallback deadline and repeatedly add failed requests to authenticated reads.
2 open findings
What changed in this PR
This PR lets RegistryFS v2 try the accelerator before resolving the canonical registry URL.
Changes:
- Sends the requested byte range directly through the configured accelerator.
- Returns successful responses immediately; otherwise continues through existing registry resolution and authentication.
| File | Description |
|---|---|
| src/overlaybd/registryfs/registryfs_v2.cpp | Adds the accelerator-first request path. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: vpatelsj <vpatelsj@gmail.com>
Signed-off-by: vpatelsj <vpatelsj@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What this PR does / why we need it:
When an accelerator is configured, RegistryFS v2 currently resolves the canonical registry blob URL before sending the data request through the accelerator. That makes the accelerator path depend on registry authentication or redirect resolution even when the accelerator can serve the canonical URL directly.
This change tries the configured accelerator first with the canonical URL and requested byte range. A
200or206response is returned immediately. Any other response continues through the existing registry resolution and authenticated request path.Validation:
git diff --checkpasses.Which issue(s) this PR fixes (optional):
None.
Please check the following list: