Repository navigation
fix(sso): start sign-in on the configured site address - #6
Merged
Merged
Conversation
A login started on the Fly hostname or an alias set the login binding cookie on that host, while the provider returned to the site address, so the callback failed with INVALID_LOGIN_STATE. Send such logins to the sign-in screen on the configured origin first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INVALID_LOGIN_STATEwhen it was started oncontext4ai-sourcegraph.fly.dev(or an alias such aswww.context4ai.org): the login binding cookie belongs to that host, but GitHub always returns tohttps://context4ai.org./sourcegraph/loginon the configured origin. Requests through the site proxy carry the original host inX-Forwarded-Hostand start at the provider as before. Redirects only target the configured origin.Test plan
TestLoginStartsOnTheSiteAddress(Fly hostname and alias redirect without setting a cookie; proxied and direct site requests start the provider login)go test ./...,go vet, public audit🤖 Generated with Claude Code