Repository navigation
Conversation
The Coolify API accepts dockerfile_location, and the dashboard exposes it, but the CLI had no flag for it: an application whose Dockerfile sits in a subdirectory of a monorepo could not be configured from the command line. The sibling build option (dockerfile_target_build) was already there, so this adds the missing half. Available on the three repository-based create commands (public, github, deploy-key) and on `app update`. The inline `dockerfile` and the `dockerimage` creates do not get it: neither has a repository to point into.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--dockerfile-locationto the repository-based application commands (app create public,app create github,app create deploy-key) and toapp update, mapped to the API'sdockerfile_location. The sibling build option (--dockerfile-target-build) was already exposed, so an application whose Dockerfile lives in a subdirectory of a monorepo could be created from the CLI but not pointed at that Dockerfile.Changes
internal/models/application.go:DockerfileLocationonApplicationCreatePublicRequest,ApplicationCreateGitHubAppRequest,ApplicationCreateDeployKeyRequestandApplicationUpdateRequest(json:"dockerfile_location,omitempty").dockerfilecreate and thedockerimagecreate do not get it: neither request body accepts the field.README.md: the flag is listed forapp updateand for the create commands.llms.txt/llms-full.txtregenerated withgo run ./coolify docs llms.Verification
go build ./...— cleango test ./cmd/... ./internal/...— all packages pass, including the newTestDockerfileLocation_MarshalRequestShape,TestDockerfileLocation_OmittedWhenUnset,TestGitCreateCommands_ExposeDockerfileLocationFlaggo run ./coolify docs llmsproduces a byte-identicalllms.txt/llms-full.txtgofmt -l .empty;golangci-lint run ./cmd/... ./internal/...reports the same 6 findings asupstream/main(3 gosec in test files, 3 govet ininternal/output/table.go), so none is newCloses #97