Repository navigation
fix(docker): parse quoted and hyphenated custom docker option values - #12208
Open
andrasbacsai wants to merge 3 commits into
Open
andrasbacsai wants to merge 3 commits into
andrasbacsai wants to merge 3 commits into
Conversation
5 of 9 tasks
…-docker-options-parser
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--security-opt no-new-privileges:truewas turned intosecurity_opt: ['no'], and the deployment then failed withinvalid security-opt: "no".--flag valueand--flag=valueforms. The parser strips the surrounding quotes, so--security-opt="no-new-privileges:true"no longer produces"\"no".--. Options inside a quoted--entrypoint(for examplesh -c '... --privileged ...') are no longer read as separate flags.--security-opt="", the option is skipped.--hostnameregex. Hostname now goes through the general value parsing, which also handles quoted hostnames.fixes #8173
Fixes #8173