Repository navigation
chore(ui): remove aria-label attributes from autocomplete and combobox - #908
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
sean-brydon
approved these changes
Oct 20, 2026
sean-brydon
deleted the
chore/remove-autocomplete-combobox-aria-labels
branch
October 20, 2026 16:06
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the hard-coded
aria-labelattributes from the built-in trigger, clear, and chip-remove buttons inAutocompleteandCombobox.AutocompleteInput: trigger ("Show options") and clear ("Clear selection")ComboboxInput: trigger ("Show options") and clear ("Clear selection")ComboboxChipRemove: "Remove"Updated in the registry source, the synced
packages/uicopies, and theautocomplete.json/combobox.jsonregistry outputs.Made with Cursor