Repository navigation
security: verify model artifacts before deserialization - #13
Merged
cr-shah merged 1 commit intoOct 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trained models previously reached joblib deserialization without verification. Require MODEL_ARTIFACT_SHA256 from trusted deployment configuration, verify both metadata and model bytes, then deserialize the exact verified snapshot. Pin changes also invalidate the API model cache.
Training emits artifact.sha256 for controlled promotion. The runtime never trusts that sidecar. Existing trained deployments must regenerate artifacts and configure the new pin on both API and worker before upgrading; demo mode is unaffected. Compose wiring and deployment instructions are included.
Verification: 191 pytest tests passed; Ruff checks passed; independent review found no actionable issues. Tests cover model/metadata tampering, executable pickle rejection before loading, file replacement races, cache pin changes, and API/worker parity.
Depends on #12. One commit relative to its base. Merge order: #10 → #11 → #12 → this PR. Retarget to main after prerequisites land; preserve ancestry with merge commits.