Repository navigation
docs: fix drift between docs, and scripts - #179
Merged
cychiang merged 5 commits intoSep 15, 2026
Merged
Conversation
…cripts - Rewrite the Developing walkthrough as ten runnable steps that build a real provider managing a Kubernetes ConfigMap, instead of an abstract stub - Flag the generated stub's meta.WasDeleted early return: keeping it means Delete never runs and the ConfigMap is orphaned - Fix stale links in PROVIDER_CHECKLIST.md and exempt it from provider.prepare's find-and-replace - Have provider.prepare and provider.addtype print the registration edits they did not make, and the API group they resolved - Make the API group domain configurable (provider.prepare domain=example.com); provider.addtype derives the suffix from the tree, so a type's group cannot disagree with the provider's own - Alias the generated API import, which goimports requires once the apiversion looks like a module major-version suffix (v1, v2) - Pin CROSSPLANE_CLI_VERSION to v2.3.4: a 1.x CLI drops spec.capabilities, so the package installs and reports Healthy but never reconciles anything - Pin GOTOOLCHAIN from go.mod: golangci-lint cannot typecheck a standard library newer than the Go that built it, and GOTOOLCHAIN=auto only upgrades Signed-off-by: Chuan-Yen Chiang <cychiang0823@gmail.com>
cychiang
changed the title
Collaborator
Author
|
Hi @jbw976 @jonasz-lasut please take a look on these changes. Trying to fix some drifts between docs, and scripts. |
jonasz-lasut
approved these changes
Sep 15, 2026
jonasz-lasut
left a comment
jonasz-lasut
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the contribution @cychiang LGTM with a few nits
Signed-off-by: Chuan-Yen Chiang <cychiang0823@gmail.com>
Signed-off-by: Chuan-Yen Chiang <cychiang0823@gmail.com>
Signed-off-by: Chuan-Yen Chiang <cychiang0823@gmail.com>
version across each step Signed-off-by: Chuan-Yen Chiang <cychiang0823@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
addType.sh, andprepare.sh. Fix some issues where not easy to add a type and domain we wantFixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested