Encapsulate Legacy Steam Market Behavior and Deprecate JQuery#397
Open
GODrums wants to merge 3 commits into
Open
Encapsulate Legacy Steam Market Behavior and Deprecate JQuery#397GODrums wants to merge 3 commits into
GODrums wants to merge 3 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a3f69c3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #396
Step 1 of #395
Gets rid of JQuery logic in shared functionality in favor of common DOM APIs.
Encapsulates existing Steam Market components to
SteamMarketMode.Legacy.Resolves all errors when using the extension with the Steam Market Beta enabled.
Note
Medium Risk
Changes shared injection and styling paths used on every market page; incorrect mode detection could skip features on legacy or leave beta issues partially unfixed.
Overview
Adds Steam Market mode detection (
legacyvs React beta) and gates legacy-only UI injection and Google Fonts loading so the extension no longer throws on the Market beta.Injection decorators now accept an optional guard; market utility belt and listing row components only inject when
isLegacySteamMarket()is true. Conflict styling inStyleConflictingElementdrops jQuery forquerySelectorAlland inlinesetProperty.Reviewed by Cursor Bugbot for commit a3f69c3. Configure here.