[Social Work] - Add full list of jurisdictions to configuration#1704
Open
landonshumway-ia wants to merge 7 commits into
Open
[Social Work] - Add full list of jurisdictions to configuration#1704landonshumway-ia wants to merge 7 commits into
landonshumway-ia wants to merge 7 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds linked-license mock generation, expands jurisdiction lists and schema snapshots, and removes export-results bucket wiring from search stacks, configs, and tests across both apps. ChangesMock License Linked-Records Generation
Jurisdiction Scope Expansion
Export Results Bucket Removal
Estimated code review effort: 4 (Complex) | ~60 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@backend/social-work-app/cdk.json`:
- Around line 22-29: The jurisdiction lists in cdk.json are missing AS and PR,
which affects scope generation and enum validation. Update both
context.jurisdictions and active_compact_member_jurisdictions.socw to include
American Samoa and Puerto Rico alongside the existing state/territory codes,
keeping the values consistent wherever jurisdiction scope is defined.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f5562587-dc5a-4ae2-8b11-3b8b49994d57
📒 Files selected for processing (2)
backend/social-work-app/bin/generate_mock_license_csv_upload_file.pybackend/social-work-app/cdk.json
This bucket construct config was replicated from the existing search stacks, but is not needed by cosm or socw
Collaborator
Author
|
@jlkravitz This is ready for your review. Thanks |
jlkravitz
previously approved these changes
Jul 2, 2026
jlkravitz
left a comment
jlkravitz
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. One small question!
jlkravitz
approved these changes
Jul 3, 2026
jlkravitz
left a comment
jlkravitz
left a comment
Collaborator
There was a problem hiding this comment.
@isabeleliassen Good to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the Cognito service team has approved our request to increase the number of resource servers allowed per user pool, we are able to include the full list of jurisdictions associated with the Social Work compact so that staff users can be added for any of those jurisdictions with needed permission scopes.
This also enhances our mock license generation script to support creating test practitioners with matching single and multi-state licenses, and performs some light cleanup of an unused S3 bucket from the Cosm and Socw CDK apps.
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsbackend/compact-connect/tests/unit/test_api.pyrun compact-connect/bin/download_oas30.pyCloses #1703
Summary by CodeRabbit
--linked-licensesmode to the mock-data generator that emits paired license records for the same practitioner (single-state + multi-state) and adjusts the meaning of the--countvalue accordingly.