Repository navigation
[CLK 6.18] spec: only require ciq-kmod on el9 - #1682
Merged
Merged
Conversation
ciq-kmod is a synthetic provide added by the patched el9 kmod (weak-modules fix for xz-compressed symvers). EL10's stock kmod already handles xz and zstd symvers and nothing there provides ciq-kmod, so the unconditional Requires makes kernel-clk6.18 uninstallable on EL10. Guard it to rhel == 9 so other EL versions do not depend on the el9-only patched kmod. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernel-clk6.18has an unconditionalRequires: ciq-kmod(added in kernel-clk6.18: add ciq-kmod Requires and ship %clk_version macro #1294).ciq-kmodis a synthetic provide added by CIQ's patched el9 kmod (theweak-modulesfix for xz-compressed symvers).weak-modules, and nothing on el10 providesciq-kmod. With [CLK 6.18] spec: Enable Rocky 10 builds #1533 enabling Rocky 10 builds, the unconditional Requires would makekernel-clk6.18uninstallable on EL10.%if 0%{?rhel} == 9. It is el9-specific, so it should not block other EL versions either (e.g. if CLK ships for 8 later).%changelogis intentionally untouched; it is regenerated from commit subjects at the next spec bump.Test plan
rpmspec -Pwith--define "rhel N":Requires: ciq-kmodis present forrhel=9and absent forrhel=8,rhel=10, and withrhelundefined.rpmspec -Pforrhel=10parses cleanly.kernel-clk6.18and an install test (not done yet).🤖 Generated with Claude Code