chore: examples improvements#13
Open
miguelangaranocurrents wants to merge 8 commits into
Open
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (38)
💤 Files with no reviewable changes (12)
📝 WalkthroughWalkthroughThis PR pins Playwright container images to v1.60.0-noble across CI, replaces hardcoded CURRENTS_PROJECT_ID values with secrets or pipeline variables, migrates CURRENTS_API_URL from staging to production, renames a staging workflow to production, and updates docs/build commands to use environment variables. ChangesCI/CD Playwright & Currents Configuration Migration
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 19
🧹 Nitpick comments (1)
playwright/ci/circleci/.circleci/config.yml (1)
5-5: ⚡ Quick winComplete the project-id env migration in this job.
While Line 5 pins the image, Line 14 still hardcodes
--project-id bnsqNa. Please switch to an environment variable to keep this example configurable across repos/environments.Proposed update
- command: SHARD="$((${CIRCLE_NODE_INDEX}+1))"; npx pwc --key $CURRENTS_RECORD_KEY --project-id bnsqNa --shard=${SHARD}/${CIRCLE_NODE_TOTAL} + command: SHARD="$((${CIRCLE_NODE_INDEX}+1))"; npx pwc --key $CURRENTS_RECORD_KEY --project-id $CURRENTS_PROJECT_ID --shard=${SHARD}/${CIRCLE_NODE_TOTAL}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@playwright/ci/circleci/.circleci/config.yml` at line 5, Replace the hardcoded project id flag (--project-id bnsqNa) with an environment variable (e.g., --project-id $PROJECT_ID) and add PROJECT_ID to the job's environment so the job is configurable; locate the job that uses the mcr.microsoft.com/playwright:v1.60.0-noble image and update the command/step that currently includes "--project-id bnsqNa" to use "--project-id $PROJECT_ID", and add an env: PROJECT_ID: your-default-or-placeholder value under that job definition so downstream repos can override it.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@playwright/ci/github-actions/.github/test-basic-pwc-staging.yml`:
- Line 45: The workflow uses ${{ env.CURRENTS_PROJECT_ID }} but that env
variable is never defined; either define CURRENTS_PROJECT_ID under the
workflow/job-level env block or (preferred) replace all occurrences of ${{
env.CURRENTS_PROJECT_ID }} (e.g., where CURRENTS_PROJECT_ID is set in the
job/step) with ${{ vars.CURRENTS_PROJECT_ID }} so it correctly reads the GitHub
repository variable; update every place this token appears (including the two
occurrences flagged) to ensure a non-empty value at runtime.
- Line 44: Replace the production API URL used for CURRENTS_API_URL with the
staging API endpoint for the staging workflow: update both occurrences where
CURRENTS_API_URL is set to "https://cy.currents.dev" (the ones paired with
CURRENTS_RECORD_KEY_STAGING) to the correct staging URL (e.g.,
"https://cy.staging.currents.dev") so the staging tests authenticate and post to
the staging API rather than production.
In `@playwright/ci/github-actions/.github/workflows/argos-example.yml`:
- Line 44: The workflow references an undefined environment variable
CURRENTS_PROJECT_ID via `${{ env.CURRENTS_PROJECT_ID }}` which will be empty and
break Currents integration; fix it by either replacing the reference with a
defined repository variable (`${{ vars.CURRENTS_PROJECT_ID }}`) or a secret
(`${{ secrets.CURRENTS_PROJECT_ID }}`) if sensitive, or by adding
CURRENTS_PROJECT_ID to the workflow-level env block so `${{
env.CURRENTS_PROJECT_ID }}` is actually defined; update the line containing
CURRENTS_PROJECT_ID to one of those three forms to resolve the error.
In `@playwright/ci/github-actions/.github/workflows/rerun-shards-pwc.yml`:
- Line 16: The workflow uses CURRENTS_PROJECT_ID via `${{
env.CURRENTS_PROJECT_ID }}` but that env variable isn't defined; update the
workflow to reference a defined variable instead (for example change the binding
to `${{ vars.CURRENTS_PROJECT_ID }}` to use a repository variable or to `${{
secrets.CURRENTS_PROJECT_ID }}` if sensitive), or add a top-level env/variables
block that defines CURRENTS_PROJECT_ID before it's used; locate the line with
`CURRENTS_PROJECT_ID: ${{ env.CURRENTS_PROJECT_ID }}` and replace or define
accordingly.
In `@playwright/ci/github-actions/.github/workflows/rerun-shards-reporter.yml`:
- Line 16: The workflow sets CURRENTS_PROJECT_ID using `${{
env.CURRENTS_PROJECT_ID }}` but that env var is not defined; update the workflow
to reference a defined source or define it at the workflow level: replace `${{
env.CURRENTS_PROJECT_ID }}` with either `${{ vars.CURRENTS_PROJECT_ID }}` for a
repository variable or `${{ secrets.CURRENTS_PROJECT_ID }}` for a secret, or add
a top-level env/key named CURRENTS_PROJECT_ID in the workflow so the existing
reference resolves (look for the CURRENTS_PROJECT_ID assignment in the job step
and update accordingly).
In `@playwright/ci/github-actions/.github/workflows/reruns-or8n.yml`:
- Line 16: The workflow uses CURRENTS_PROJECT_ID via the expression `${{
env.CURRENTS_PROJECT_ID }}` but that environment variable is not defined in this
workflow; replace or define it so the Currents integration receives a value. Fix
by either switching the reference to a repository variable (`${{
vars.CURRENTS_PROJECT_ID }}`) or to a secret (`${{ secrets.CURRENTS_PROJECT_ID
}}`) if sensitive, or add a top-level env definition for CURRENTS_PROJECT_ID in
the workflow so `${{ env.CURRENTS_PROJECT_ID }}` resolves correctly; update the
line referencing CURRENTS_PROJECT_ID accordingly.
In `@playwright/ci/github-actions/.github/workflows/test-basic-pwc.yml`:
- Line 44: The workflow references an undefined environment variable
CURRENTS_PROJECT_ID, which will produce an empty value; fix it by either
switching the reference to a repository variable or secret or by defining it at
the workflow level: replace usages of ${{ env.CURRENTS_PROJECT_ID }} with ${{
vars.CURRENTS_PROJECT_ID }} for a repo variable or ${{
secrets.CURRENTS_PROJECT_ID }} for a secret, or add CURRENTS_PROJECT_ID to the
workflow's env block so the key used in the job (CURRENTS_PROJECT_ID) is defined
before it's referenced.
In
`@playwright/ci/github-actions/.github/workflows/test-basic-reporter-with-summary.yml`:
- Line 43: The workflow references `${{ env.CURRENTS_PROJECT_ID }}` which is not
defined and will be empty; update the CURRENTS_PROJECT_ID environment reference
to a defined source—either change the expression to `${{
vars.CURRENTS_PROJECT_ID }}` to use a repository variable, `${{
secrets.CURRENTS_PROJECT_ID }}` if it’s sensitive, or add a top-level env
definition for CURRENTS_PROJECT_ID in the workflow so the symbol
CURRENTS_PROJECT_ID is populated when the job runs.
In `@playwright/ci/github-actions/.github/workflows/test-basic-reporter.yml`:
- Line 43: The workflow references an undefined environment variable
CURRENTS_PROJECT_ID (CURRENTS_PROJECT_ID: ${{ env.CURRENTS_PROJECT_ID }}) which
will be empty and break Currents integration; fix it by replacing the env
reference with a defined source (e.g., use repository variables:
CURRENTS_PROJECT_ID: ${{ vars.CURRENTS_PROJECT_ID }}, or use a secret:
CURRENTS_PROJECT_ID: ${{ secrets.CURRENTS_PROJECT_ID }}), or define
CURRENTS_PROJECT_ID at the workflow level before use so the CURRENTS_PROJECT_ID
key has a valid value.
In `@playwright/ci/github-actions/.github/workflows/test-or8n.yml`:
- Line 45: The workflow references an undefined environment variable using ${{
env.CURRENTS_PROJECT_ID }}, which will be empty and break Currents integration;
fix it by either replacing that reference with a repository variable or secret
(e.g. use ${{ vars.CURRENTS_PROJECT_ID }} or ${{ secrets.CURRENTS_PROJECT_ID
}}), or define CURRENTS_PROJECT_ID at the workflow-level env before it's
referenced; update the single occurrence of CURRENTS_PROJECT_ID (the key used in
the job/env mapping) to one of these valid sources so the value is populated at
runtime.
In `@playwright/ci/github-actions/argos/argos-example.yml`:
- Line 44: Replace the undefined environment variable reference
CURRENTS_PROJECT_ID in the workflow with the repository-level variable access:
change occurrences of ${{ env.CURRENTS_PROJECT_ID }} to ${{
vars.CURRENTS_PROJECT_ID }} so the Argos step receives the configured project
ID; update the value used where CURRENTS_PROJECT_ID is set in the Argos/job step
to reference vars instead of env.
In `@playwright/ci/nx/.github/workflows/e2e.yml`:
- Line 32: The workflow references an undefined env variable CURRENTS_PROJECT_ID
(${ { env.CURRENTS_PROJECT_ID } }) which will be empty at runtime; replace that
reference with the repository-level variable syntax (${ {
vars.CURRENTS_PROJECT_ID } }) or explicitly define CURRENTS_PROJECT_ID in the
workflow's env block before use so the Currents upload receives a real project
ID; update the key where CURRENTS_PROJECT_ID is set (the line using
CURRENTS_PROJECT_ID) to use ${ { vars.CURRENTS_PROJECT_ID } } or add an env:
CURRENTS_PROJECT_ID: ${{ secrets.OR_OTHER_SOURCE }} entry.
In `@playwright/ci/nx/.github/workflows/or8n.yml`:
- Line 32: The workflow sets CURRENTS_PROJECT_ID using the wrong context
(CURRENTS_PROJECT_ID: ${{env.CURRENTS_PROJECT_ID}}) which will be empty at
runtime; update that assignment to reference the correct GitHub context where
the project ID is stored (e.g., change to ${{secrets.CURRENTS_PROJECT_ID}} or
${{vars.CURRENTS_PROJECT_ID}}) so the Currents integration receives the real
value.
In `@playwright/currents-actions/.github/workflows/test-pwcp.yml`:
- Line 43: Replace the incorrect use of the runner environment for
CURRENTS_PROJECT_ID (currently referenced as ${{ env.CURRENTS_PROJECT_ID }})
with the appropriate GitHub Actions context: use ${{ vars.CURRENTS_PROJECT_ID }}
for a repository variable or ${{ secrets.CURRENTS_PROJECT_ID }} if it is
sensitive, matching how CURRENTS_RECORD_KEY is handled; update the
CURRENTS_PROJECT_ID entry in the workflow to reference the chosen context so it
resolves correctly at runtime.
In `@playwright/currents-actions/.github/workflows/tests-pwc.yml`:
- Line 43: The workflow sets CURRENTS_PROJECT_ID using `${{
env.CURRENTS_PROJECT_ID }}` which is undefined at runtime; update that
environment binding to use the appropriate secret or variable (e.g., `${{
secrets.CURRENTS_PROJECT_ID }}` or `${{ vars.CURRENTS_PROJECT_ID }}`) consistent
with how CURRENTS_RECORD_KEY is defined so the step receives a non-empty value
for CURRENTS_PROJECT_ID.
In `@playwright/currents-actions/.github/workflows/tests-reporter.yml`:
- Line 43: The workflow currently uses env.CURRENTS_PROJECT_ID which is
undefined so it expands to an empty string; update the workflow so the
CURRENTS_PROJECT_ID value is sourced from a defined context (for example change
the reference to vars.CURRENTS_PROJECT_ID or set CURRENTS_PROJECT_ID in the
workflow/job-level env) and ensure the key referenced in the YAML
(CURRENTS_PROJECT_ID) matches the variable name stored in GitHub Variables or
the env block; locate the environment mapping line containing
"CURRENTS_PROJECT_ID: ${{ env.CURRENTS_PROJECT_ID }}" and replace it with the
appropriate defined source or add the missing env entry at the job or workflow
level so the value is populated.
In `@playwright/orchestration/.github/workflows/or8n.yml`:
- Line 42: The workflow references CURRENTS_PROJECT_ID (used when running the
npx pwc-p run step) but that env var is not defined in the workflow or job scope
so it will be empty at runtime; fix it by defining CURRENTS_PROJECT_ID either as
a repository secret and using ${{ secrets.CURRENTS_PROJECT_ID }}, as a
repository variable with ${{ vars.CURRENTS_PROJECT_ID }}, or by adding an env:
block at the job or workflow level that sets CURRENTS_PROJECT_ID to the correct
value so the npx pwc-p run invocation receives a real project id.
In `@playwright/orchestration/.github/workflows/shard.yml`:
- Line 42: The workflow is using an undeclared environment variable
CURRENTS_PROJECT_ID via `${{ env.CURRENTS_PROJECT_ID }}`; update the step to
reference the repository variable context `${{ vars.CURRENTS_PROJECT_ID }}`
instead, or alternatively add a job-level env: block that defines
CURRENTS_PROJECT_ID before the step. Locate the occurrence of
`CURRENTS_PROJECT_ID` in the shard.yml workflow and replace the `${{
env.CURRENTS_PROJECT_ID }}` reference with `${{ vars.CURRENTS_PROJECT_ID }}` (or
add the job-level `env:` entry to expose the value).
In `@playwright/pnpm/.github/workflows/integration.yml`:
- Line 50: The workflow references CURRENTS_PROJECT_ID via ${{
env.CURRENTS_PROJECT_ID }} which is not defined and will be empty at runtime;
update the workflow so the step receives a valid value by either changing the
reference to ${{ secrets.CURRENTS_PROJECT_ID }} if the project ID should come
from GitHub Secrets, or define CURRENTS_PROJECT_ID under the workflow/job env
block so ${{ env.CURRENTS_PROJECT_ID }} is populated; look for the key name
CURRENTS_PROJECT_ID in the integration.yml and update the usage accordingly.
---
Nitpick comments:
In `@playwright/ci/circleci/.circleci/config.yml`:
- Line 5: Replace the hardcoded project id flag (--project-id bnsqNa) with an
environment variable (e.g., --project-id $PROJECT_ID) and add PROJECT_ID to the
job's environment so the job is configurable; locate the job that uses the
mcr.microsoft.com/playwright:v1.60.0-noble image and update the command/step
that currently includes "--project-id bnsqNa" to use "--project-id $PROJECT_ID",
and add an env: PROJECT_ID: your-default-or-placeholder value under that job
definition so downstream repos can override it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8812df99-2c8e-44db-ac79-9fe60965a535
📒 Files selected for processing (27)
generic-reporter/junit/junit-xml/.github/workflows/sharded-vitest.ymlplaywright/ci/azure-devops/analysis.mdplaywright/ci/azure-devops/azure-pipelines-reporter.ymlplaywright/ci/azure-devops/azure-pipelines.ymlplaywright/ci/buildkite/.buildkite/pipeline.ymlplaywright/ci/circleci/.circleci/config.ymlplaywright/ci/github-actions/.github/test-basic-pwc-staging.ymlplaywright/ci/github-actions/.github/workflows/argos-example.ymlplaywright/ci/github-actions/.github/workflows/rerun-shards-pwc.ymlplaywright/ci/github-actions/.github/workflows/rerun-shards-reporter.ymlplaywright/ci/github-actions/.github/workflows/reruns-or8n.ymlplaywright/ci/github-actions/.github/workflows/test-basic-pwc.ymlplaywright/ci/github-actions/.github/workflows/test-basic-reporter-with-summary.ymlplaywright/ci/github-actions/.github/workflows/test-basic-reporter.ymlplaywright/ci/github-actions/.github/workflows/test-or8n.ymlplaywright/ci/github-actions/analysis.mdplaywright/ci/github-actions/argos/argos-example.ymlplaywright/ci/jenkins/jenkins-last-failed/Jenkinsfile.dockerplaywright/ci/nx/.github/workflows/e2e.ymlplaywright/ci/nx/.github/workflows/or8n.ymlplaywright/currents-actions/.github/workflows/test-pwcp.ymlplaywright/currents-actions/.github/workflows/tests-pwc.ymlplaywright/currents-actions/.github/workflows/tests-reporter.ymlplaywright/orchestration/.github/workflows/or8n.ymlplaywright/orchestration/.github/workflows/shard.ymlplaywright/pnpm/.github/workflows/integration.ymlplaywright/pnpm/analysis.md
💤 Files with no reviewable changes (3)
- playwright/pnpm/analysis.md
- playwright/ci/azure-devops/analysis.md
- playwright/ci/github-actions/analysis.md
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (2)
playwright/ci/github-actions/.github/test-basic-pwc-staging.yml (2)
54-56:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winStaging workflow incorrectly configured with production API endpoint and credentials.
Same issue as the previous step: lines 54 and 56 configure the staging workflow to use production Currents API and credentials instead of staging endpoints.
🔧 Proposed fix
- CURRENTS_API_URL: https://cy.currents.dev + CURRENTS_API_URL: https://cy-staging.currents.dev CURRENTS_PROJECT_ID: ${{ vars.CURRENTS_PROJECT_ID }} - CURRENTS_RECORD_KEY: ${{ secrets.CURRENTS_RECORD_KEY }} + CURRENTS_RECORD_KEY: ${{ secrets.CURRENTS_RECORD_KEY_STAGING }}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@playwright/ci/github-actions/.github/test-basic-pwc-staging.yml` around lines 54 - 56, Update the staging GitHub Actions workflow environment variables so it uses the staging Currents endpoint and credentials: replace CURRENTS_API_URL value "https://cy.currents.dev" with the staging API URL, ensure CURRENTS_PROJECT_ID references the staging project variable (not the production one), and swap CURRENTS_RECORD_KEY to the staging secret instead of the production secret; update the three env vars CURRENTS_API_URL, CURRENTS_PROJECT_ID and CURRENTS_RECORD_KEY in the workflow to point to the correct staging values/secrets.
44-46:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winStaging workflow incorrectly configured with production API endpoint and credentials.
This workflow is named
demo.playwright.pwc.stagingand resides in a file namedtest-basic-pwc-staging.yml, but lines 44 and 46 configure it to use the production Currents API (https://cy.currents.dev) and production record key (secrets.CURRENTS_RECORD_KEY). This configuration mismatch will route staging test results to the production environment, potentially causing authentication failures or mixing staging data with production data.🔧 Proposed fix
- CURRENTS_API_URL: https://cy.currents.dev + CURRENTS_API_URL: https://cy-staging.currents.dev CURRENTS_PROJECT_ID: ${{ vars.CURRENTS_PROJECT_ID }} - CURRENTS_RECORD_KEY: ${{ secrets.CURRENTS_RECORD_KEY }} + CURRENTS_RECORD_KEY: ${{ secrets.CURRENTS_RECORD_KEY_STAGING }}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@playwright/ci/github-actions/.github/test-basic-pwc-staging.yml` around lines 44 - 46, The staging workflow is pointing at production credentials and endpoint; update the CURRENTS_* environment variables so the workflow uses staging values: replace the hardcoded CURRENTS_API_URL (https://cy.currents.dev) with a staging API URL or a staging var (e.g., vars.CURRENTS_STAGING_API_URL) and switch CURRENTS_PROJECT_ID and CURRENTS_RECORD_KEY to their staging counterparts (e.g., vars.CURRENTS_STAGING_PROJECT_ID and secrets.CURRENTS_STAGING_RECORD_KEY) so demo.playwright.pwc.staging targets the staging Currents environment.
🧹 Nitpick comments (1)
generic-reporter/junit/nodejs-github-actions/.github/workflows/test.yml (1)
45-45: ⚡ Quick winConsider migrating hardcoded project ID to repository variable for consistency.
Line 45 still uses a hardcoded project ID (
JOw2i3) while the PR migrates other workflows to use${{ vars.CURRENTS_PROJECT_ID }}. For consistency with the rest of the codebase and to centralize configuration management, consider replacing the hardcoded value with the repository variable.♻️ Proposed refactor
- CURRENTS_API_URL=https://cy.currents.dev/ npx currents upload --project-id JOw2i3 --ci-build-id ${{ github.repository }}-${{ github.run_id }}-${{ github.run_attempt }} + CURRENTS_API_URL=https://cy.currents.dev/ npx currents upload --project-id ${{ vars.CURRENTS_PROJECT_ID }} --ci-build-id ${{ github.repository }}-${{ github.run_id }}-${{ github.run_attempt }}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@generic-reporter/junit/nodejs-github-actions/.github/workflows/test.yml` at line 45, Replace the hardcoded project ID in the GitHub Actions step that runs "npx currents upload" (the command using CURRENTS_API_URL and --ci-build-id) with the repository variable used elsewhere (${ { vars.CURRENTS_PROJECT_ID }}), i.e., update the --project-id JOw2i3 token to reference the repo variable so the upload step uses vars.CURRENTS_PROJECT_ID for centralized configuration and consistency with other workflows.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@playwright/ci/github-actions/.github/test-basic-pwc-staging.yml`:
- Around line 54-56: Update the staging GitHub Actions workflow environment
variables so it uses the staging Currents endpoint and credentials: replace
CURRENTS_API_URL value "https://cy.currents.dev" with the staging API URL,
ensure CURRENTS_PROJECT_ID references the staging project variable (not the
production one), and swap CURRENTS_RECORD_KEY to the staging secret instead of
the production secret; update the three env vars CURRENTS_API_URL,
CURRENTS_PROJECT_ID and CURRENTS_RECORD_KEY in the workflow to point to the
correct staging values/secrets.
- Around line 44-46: The staging workflow is pointing at production credentials
and endpoint; update the CURRENTS_* environment variables so the workflow uses
staging values: replace the hardcoded CURRENTS_API_URL (https://cy.currents.dev)
with a staging API URL or a staging var (e.g., vars.CURRENTS_STAGING_API_URL)
and switch CURRENTS_PROJECT_ID and CURRENTS_RECORD_KEY to their staging
counterparts (e.g., vars.CURRENTS_STAGING_PROJECT_ID and
secrets.CURRENTS_STAGING_RECORD_KEY) so demo.playwright.pwc.staging targets the
staging Currents environment.
---
Nitpick comments:
In `@generic-reporter/junit/nodejs-github-actions/.github/workflows/test.yml`:
- Line 45: Replace the hardcoded project ID in the GitHub Actions step that runs
"npx currents upload" (the command using CURRENTS_API_URL and --ci-build-id)
with the repository variable used elsewhere (${ { vars.CURRENTS_PROJECT_ID }}),
i.e., update the --project-id JOw2i3 token to reference the repo variable so the
upload step uses vars.CURRENTS_PROJECT_ID for centralized configuration and
consistency with other workflows.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6c8bfdbf-510e-462d-8123-bd17dfe6406c
📒 Files selected for processing (28)
cypress/azure-devops/analysis.mdcypress/circleci/analysis.mdcypress/cucumber/analysis.mdcypress/github-actions/analysis.mdgeneric-reporter/junit/junit-xml/.github/workflows/sharded-vitest.ymlgeneric-reporter/junit/nodejs-github-actions/.github/workflows/test.ymlgeneric-reporter/junit/nodejs-github-actions/analysis.mdgeneric-reporter/junit/nodejs-github-actions/package.jsonplaywright/bdd-cucumber/analysis.mdplaywright/ci/github-actions/.github/test-basic-pwc-staging.ymlplaywright/ci/github-actions/.github/workflows/argos-example.ymlplaywright/ci/github-actions/.github/workflows/rerun-shards-pwc.ymlplaywright/ci/github-actions/.github/workflows/rerun-shards-reporter.ymlplaywright/ci/github-actions/.github/workflows/reruns-or8n.ymlplaywright/ci/github-actions/.github/workflows/test-basic-pwc.ymlplaywright/ci/github-actions/.github/workflows/test-basic-reporter-with-summary.ymlplaywright/ci/github-actions/.github/workflows/test-basic-reporter.ymlplaywright/ci/github-actions/.github/workflows/test-or8n.ymlplaywright/ci/github-actions/argos/argos-example.ymlplaywright/ci/nx/.github/workflows/e2e.ymlplaywright/ci/nx/.github/workflows/or8n.ymlplaywright/ci/nx/analysis.mdplaywright/currents-actions/.github/workflows/test-pwcp.ymlplaywright/currents-actions/.github/workflows/tests-pwc.ymlplaywright/currents-actions/.github/workflows/tests-reporter.ymlplaywright/orchestration/.github/workflows/or8n.ymlplaywright/orchestration/.github/workflows/shard.ymlplaywright/pnpm/.github/workflows/integration.yml
💤 Files with no reviewable changes (7)
- playwright/ci/nx/analysis.md
- generic-reporter/junit/nodejs-github-actions/analysis.md
- cypress/cucumber/analysis.md
- cypress/github-actions/analysis.md
- cypress/azure-devops/analysis.md
- cypress/circleci/analysis.md
- playwright/bdd-cucumber/analysis.md
✅ Files skipped from review due to trivial changes (1)
- generic-reporter/junit/junit-xml/.github/workflows/sharded-vitest.yml
🚧 Files skipped from review as they are similar to previous changes (13)
- playwright/currents-actions/.github/workflows/test-pwcp.yml
- playwright/orchestration/.github/workflows/shard.yml
- playwright/currents-actions/.github/workflows/tests-reporter.yml
- playwright/ci/github-actions/.github/workflows/rerun-shards-reporter.yml
- playwright/ci/github-actions/.github/workflows/reruns-or8n.yml
- playwright/currents-actions/.github/workflows/tests-pwc.yml
- playwright/ci/github-actions/.github/workflows/test-basic-pwc.yml
- playwright/pnpm/.github/workflows/integration.yml
- playwright/ci/github-actions/.github/workflows/test-basic-reporter.yml
- playwright/orchestration/.github/workflows/or8n.yml
- playwright/ci/github-actions/argos/argos-example.yml
- playwright/ci/github-actions/.github/workflows/test-basic-reporter-with-summary.yml
- playwright/ci/github-actions/.github/workflows/test-or8n.yml
miguelangaranocurrents
requested review from
maxigimenez
and removed request for
maxigimenez
Collaborator
Author
|
@coderabbitai approve this PR if everything is ok with it |
Contributor
|
Approving the PR. ✅ Actions performedComments resolved. Approval is disabled; enable |
Collaborator
Author
|
@coderabbitai the PR is still not approved by you |
Contributor
|
✅ Actions performedComments resolved. Approval is disabled; enable |
Collaborator
Author
|
@coderabbitai review this PR |
Contributor
|
✅ Actions performedReview triggered.
|
Collaborator
Author
|
@coderabbitai approve |
Contributor
✅ Actions performedComments resolved. Approval is disabled; enable |
maxigimenez
requested changes
May 19, 2026
maxigimenez
left a comment
maxigimenez
left a comment
There was a problem hiding this comment.
We should always use secrets. for Currents env, otherwise we are expecting the vars to be part of the yaml file which is not the case.
Also, what's the reason the analysis.md is removed? Just out of curiosity
Collaborator
Author
@maxigimenez the |
|
@coderabbitai review this PR |
Contributor
|
✅ Actions performedFull review triggered. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
gitlab/README.md (1)
14-21:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd setup instructions for
CURRENTS_PROJECT_ID.The command now depends on
$CURRENTS_PROJECT_ID, but Setup doesn’t instruct users to add that CI/CD variable, so the example can fail for first-time setup.📘 Suggested doc patch
- Add `CURRENTS_RECORD_KEY` as [GitLab CI/CD Secrets](https://docs.gitlab.com/ee/ci/variables/) (make sure it's not protected) +- Add `CURRENTS_PROJECT_ID` as [GitLab CI/CD variable](https://docs.gitlab.com/ee/ci/variables/) - [Optional] Add `CURRENTS_API_KEY` as [GitLab CI/CD Secrets](https://docs.gitlab.com/ee/ci/variables/) (only used in the examples with `npx currents api` commands)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@gitlab/README.md` around lines 14 - 21, The README's CI example uses $CURRENTS_PROJECT_ID but the Setup instructions never tell users to add it; update the Setup section to instruct users to add CURRENTS_PROJECT_ID as a GitLab CI/CD variable/secret (same guidance as CURRENTS_RECORD_KEY: not protected), and mention it is required for the npx pwc command and any npx currents api examples that use CURRENTS_PROJECT_ID so first-time runs won't fail.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@playwright/ci/aws-codebuild/README.md`:
- Line 92: Add an explicit step to the README documenting how to set the
CURRENTS_PROJECT_ID environment variable in the CodeBuild project (similar to
the existing CURRENTS_RECORD_KEY step): state that users must add
CURRENTS_PROJECT_ID to the project environment variables (or as a secure
parameter if preferred) and show that it is referenced by the command using
$CURRENTS_PROJECT_ID (alongside the existing CURRENTS_RECORD_KEY and
CODEBUILD_INITIATOR examples), so the example npx pwc --project-id
$CURRENTS_PROJECT_ID --key $CURRENTS_RECORD_KEY --ci-build-id
$CODEBUILD_INITIATOR --shard $WORKER/3 will work as documented.
---
Outside diff comments:
In `@gitlab/README.md`:
- Around line 14-21: The README's CI example uses $CURRENTS_PROJECT_ID but the
Setup instructions never tell users to add it; update the Setup section to
instruct users to add CURRENTS_PROJECT_ID as a GitLab CI/CD variable/secret
(same guidance as CURRENTS_RECORD_KEY: not protected), and mention it is
required for the npx pwc command and any npx currents api examples that use
CURRENTS_PROJECT_ID so first-time runs won't fail.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 95783625-9b12-4d0b-bd11-6fef1f08b166
📒 Files selected for processing (38)
cypress/azure-devops/analysis.mdcypress/circleci/analysis.mdcypress/cucumber/analysis.mdcypress/github-actions/analysis.mdgeneric-reporter/jest/github-actions/.github/workflows/test.ymlgeneric-reporter/jest/github-actions/analysis.mdgeneric-reporter/junit/nodejs-github-actions/.github/workflows/test.ymlgeneric-reporter/junit/nodejs-github-actions/analysis.mdgeneric-reporter/junit/nodejs-github-actions/package.jsongitlab/README.mdplaywright/bdd-cucumber/analysis.mdplaywright/ci/aws-codebuild/README.mdplaywright/ci/aws-codebuild/buildspec.ymlplaywright/ci/azure-devops/analysis.mdplaywright/ci/azure-devops/azure-pipelines-reporter.ymlplaywright/ci/azure-devops/azure-pipelines.ymlplaywright/ci/buildkite/.buildkite/pipeline.ymlplaywright/ci/circleci/.circleci/config.ymlplaywright/ci/github-actions/.github/test-basic-pwc.ymlplaywright/ci/github-actions/.github/workflows/argos-example.ymlplaywright/ci/github-actions/.github/workflows/rerun-shards-pwc.ymlplaywright/ci/github-actions/.github/workflows/rerun-shards-reporter.ymlplaywright/ci/github-actions/.github/workflows/reruns-or8n.ymlplaywright/ci/github-actions/.github/workflows/test-basic-pwc.ymlplaywright/ci/github-actions/.github/workflows/test-basic-reporter-with-summary.ymlplaywright/ci/github-actions/.github/workflows/test-basic-reporter.ymlplaywright/ci/github-actions/.github/workflows/test-or8n.ymlplaywright/ci/github-actions/analysis.mdplaywright/ci/github-actions/argos/argos-example.ymlplaywright/ci/github-actions/content-map.mdplaywright/ci/jenkins/jenkins-last-failed/Jenkinsfile.dockerplaywright/ci/nx/.github/workflows/e2e.ymlplaywright/ci/nx/.github/workflows/or8n.ymlplaywright/ci/nx/analysis.mdplaywright/orchestration/.github/workflows/or8n.ymlplaywright/orchestration/.github/workflows/shard.ymlplaywright/pnpm/.github/workflows/integration.ymlplaywright/pnpm/analysis.md
💤 Files with no reviewable changes (12)
- generic-reporter/junit/nodejs-github-actions/analysis.md
- playwright/bdd-cucumber/analysis.md
- cypress/circleci/analysis.md
- cypress/github-actions/analysis.md
- playwright/ci/nx/analysis.md
- generic-reporter/jest/github-actions/analysis.md
- playwright/ci/github-actions/content-map.md
- playwright/ci/azure-devops/analysis.md
- cypress/azure-devops/analysis.md
- playwright/ci/github-actions/analysis.md
- playwright/pnpm/analysis.md
- cypress/cucumber/analysis.md
|
@coderabbitai review this PR |
Contributor
🧩 Analysis chain🏁 Script executed: Length of output: 3180
Key findings:
✅ Actions performedFull review triggered. |
maxigimenez
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit