Fix #58: highlight script attributes appearing before type#115
Conversation
The inline_script rule matched the opening <script> tag with a greedy `.*type=` that consumed every character up to the type attribute. Any attribute placed before type (e.g. <script id="foo" type="...">) was swallowed into a single unscoped token and lost its highlighting. Replace the consuming `.*type=...` with a non-consuming lookahead that only asserts a handlebars type exists somewhere in the tag, so the begin match ends right after <script and the existing #tag-stuff rules highlight every attribute regardless of order. The now-unused type/value beginCaptures are removed. Applied to all three grammar files. Adds regression tests covering both attribute orders plus a guard that a plain text/javascript script is not treated as a handlebars embedding.
|
Warning Review limit reached
Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The inline_script rule matched the opening <script> tag with a greedy
.*type=that consumed every character up to the type attribute. Any attribute placed before type (e.g. <script id="foo" type="...">) was swallowed into a single unscoped token and lost its highlighting.Replace the consuming
.*type=...with a non-consuming lookahead that only asserts a handlebars type exists somewhere in the tag, so the begin match ends right after <script and the existing #tag-stuff rules highlight every attribute regardless of order. The now-unused type/value beginCaptures are removed.Applied to all three grammar files. Adds regression tests covering both attribute orders plus a guard that a plain text/javascript script is not treated as a handlebars embedding.