Repository navigation
fix(host): keep profile settings across helper restarts - #159
Closed
dantraynor wants to merge 1 commit into
Closed
dantraynor wants to merge 1 commit into
dantraynor wants to merge 1 commit into
Conversation
tsnet.Server.Start replaces a profile's stored prefs with defaults on every launch, keeping only the node identity. After a browser or helper restart a custom coordination server, hostname, Shields Up, LAN access, DNS, SSH, advertised routes, and a disabled subnet-route setting all reverted. With a custom server, the node then contacted the default control plane. Read the current profile's saved prefs from the state store before Start, pass the coordination server and hostname into tsnet, and reapply the remaining settings in the startup edit. Profiles with no saved prefs keep the existing startup defaults. Fixes #153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.