Repository navigation
fix(install): keep gh probes from aborting on Windows PowerShell 5.1 - #171
Merged
Merged
Conversation
With ErrorActionPreference=Stop, Windows PowerShell 5.1 turns redirected native stderr into a terminating NativeCommandError. A gh that is installed but not logged in therefore aborted the install before the exit-code check could print the intended warning. Run the gh probes with a local Continue preference and rely on the exit code. Fixes #151
dantraynor
force-pushed
the
fix/install-ps1-gh-probe
branch
from
November 13, 2026 07:17
ffd5c67 to
7998ee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Run the three
ghprobes inTest-AvailableAttestationthrough a smallInvoke-GhProbehelper with a local$ErrorActionPreference = 'Continue', and rely on$LASTEXITCODEas before.Why
Under Windows PowerShell 5.1 with
$ErrorActionPreference = 'Stop', redirected native stderr becomes a terminatingNativeCommandError. Whenghwas installed but not logged in,gh auth statusaborted the install before the intended "not authenticated" warning. PowerShell 7 was unaffected.Fixes #151
How to Test
scripts/install.test.ps1under pwsh and stock Windows PowerShell 5.1 (CIhost-windows-tests). New test puts a fakeghonPATHthat writes to stderr and exits 1 forauth status, and expects the warning instead of a throw.