Skip to content

Bump Smartnode to v1.20.3 + fix auto-bump workflow#24

Closed
saju01 wants to merge 2 commits into
dappnode:mainfrom
saju01:bump-smartnode-1.20.3
Closed

Bump Smartnode to v1.20.3 + fix auto-bump workflow#24
saju01 wants to merge 2 commits into
dappnode:mainfrom
saju01:bump-smartnode-1.20.3

Conversation

@saju01

@saju01 saju01 commented May 31, 2026

Copy link
Copy Markdown

What

  1. Bumps the bundled Smartnode from v1.19.3 → v1.20.3 (latest stable upstream, published 2026-05-21). The package was ~3 months behind.
  2. Fixes the auto_check.yml upstream-bump workflow so future Smartnode releases open PRs automatically.

Changes

  • docker-compose.yml: UPSTREAM_VERSION v1.19.3 → v1.20.3
  • dappnode_package.json: upstreamVersion v1.19.3 → v1.20.3; package version 0.1.8 → 0.1.9
  • .github/workflows/auto_check.yml:
    • push trigger branch mastermain (repo default is main, so it never fired on merges)
    • add permissions: contents: write / pull-requests: write (the default read-only GITHUB_TOKEN can't create the branch/PR that dappnodesdk bump-upstream needs)
    • actions/checkout@v2@v4; add workflow_dispatch for manual runs

Notes

  • v1.20.3 is the current latest stable Smartnode release — fetched via the existing build/Dockerfile linux-amd64 CLI + daemon assets, so no build changes needed.
  • This stable line includes the new Saturn/megapool CLI command groups in the bundled Smartnode binary. This PR does not add Dappnode-specific UI flows for 4-ETH/megapool deposits; it keeps the package update scoped to the stable binary bump, native-mode settings alignment, and auto-bump workflow repair.
  • Like the immich package, the scheduled bump workflow may need a one-time re-enable in the repo Actions tab if GitHub has auto-disabled it for inactivity.

- UPSTREAM_VERSION / upstreamVersion v1.19.3 -> v1.20.3 (latest stable
  Smartnode release, 2026-05-21); package version 0.1.8 -> 0.1.9.
- Fix auto_check.yml so future Smartnode releases auto-PR:
  - push trigger watched 'master' but default branch is 'main'
  - no permissions block -> read-only GITHUB_TOKEN could not open the
    bump branch/PR (dappnodesdk bump-upstream needs write)
  - bumped actions/checkout v2 -> v4; added workflow_dispatch
@saju01

saju01 commented May 31, 2026

Copy link
Copy Markdown
Author

Hi @mgarciate 👋 — would you be able to review this when you get a chance?

Quick summary of what's here:

  1. Smartnode bump v1.19.3 → v1.20.3 (latest stable upstream). This is the version that ships the Saturn 1 megapool / 4-ETH validator tooling, so it'd be great to get node operators onto it.
  2. A fix for the auto_check.yml upstream-bump workflow, which has actually been failing on every scheduled run (and is now auto-disabled by GitHub for inactivity):
    • push trigger watched master but the default branch is main → never fired
    • no permissions block → the read-only GITHUB_TOKEN couldn't open the bump branch/PR
    • bumped actions/checkout@v2 → v4

The workflow fix should let future Smartnode releases auto-PR again (with a one-time re-enable in the Actions tab after merge). No conflicts, 3 files changed. Happy to adjust anything. Thanks! 🙏

- Add the v1.20.x native-mode Smartnode HTTP API port default (8280) to the generated settings template without exposing it publicly.\n- Add Lodestar's QUIC P2P port default (8001), matching the existing Lighthouse/Prysm entries and upstream v1.20.3 config.\n- Add the explicit IPv6 default (disabled) and align root.version with the bundled Smartnode v1.20.3.
@saju01

saju01 commented Jun 2, 2026

Copy link
Copy Markdown
Author

Follow-up from the upstream Smartnode confirmation in rocket-pool/smartnode#1109: I pushed one more small commit to align this package's generated native-mode settings template with v1.20.3.

What changed:

  • added smartnode.apiPort: "8280" — this is the new internal Smartnode HTTP API default; the PR does not publish/expose this port
  • added lodestar.p2pQuicPort: "8001" — Lighthouse/Prysm already had this default in the template; Lodestar now supports it too
  • added root.enableIPv6: "false" — explicit upstream default for the new IPv6 setting
  • updated root.version in the template to v1.20.3 so fresh installs match the bundled Smartnode version

I intentionally did not add any public port mappings or broader Saturn/megapool UX changes here, to keep this PR as the safe stable bump + broken auto-bump workflow repair. The new megapool / claims CLI command groups are present in the bundled Smartnode binary after this bump; any Dappnode-specific UI/docs work around them can be a separate follow-up.

@mgarciate

Copy link
Copy Markdown
Collaborator

Great job @saju01 . Please, create this PR on https://github.com/dappnode/DAppNodePackage-rocketpool-testnet

@3alpha

3alpha commented Jun 24, 2026

Copy link
Copy Markdown
Member

We had big reorg of workflows, I think this is overriden by #28

@saju01

saju01 commented Jun 24, 2026

Copy link
Copy Markdown
Author

Thanks @3alpha — agreed, this is superseded. #28 (tropibot) takes the package straight to Smartnode v1.20.5, which is newer than the v1.20.3 bump here, and your workflow reorg replaces the auto_check.yml fix I'd included. Closing this as obsolete. 👍

Just to flag for visibility: the megapool validator deposit UI + API work is a separate change in #25 (and the Hoodi/testnet mirror in rocketpool-testnet#154) — that's the part that isn't covered by the auto-bump, since #28 only bumps the daemon version. I've confirmed it stays compatible on top of v1.20.5 (v1.20.4/v1.20.5 are client + bugfix releases only; no Smartnode HTTP API route changes). Happy to rebase #25 onto current main whenever it's useful.

@saju01 saju01 closed this Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants