Skip to content

chore: bump rust-dashcore to 647fa98#4022

Merged
lklimek merged 2 commits into
v4.1-devfrom
build/rust-dashcore-647fa98
Jul 6, 2026
Merged

chore: bump rust-dashcore to 647fa98#4022
lklimek merged 2 commits into
v4.1-devfrom
build/rust-dashcore-647fa98

Conversation

@lklimek

@lklimek lklimek commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

just a minor rust-dashcore bump

Summary by CodeRabbit

  • Chores
    • Updated the bundled Dash-related dependencies to a newer revision.

@lklimek lklimek requested a review from QuantumExplorer as a code owner July 6, 2026 08:01
@github-actions github-actions Bot added this to the v4.1.0 milestone Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fe092ec4-a67b-4311-990d-b6b6fee985d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR updates the git rev pin for eight Dash-related workspace dependencies in Cargo.toml, moving them from commit c88264e... to 647fa98.... No other manifest sections or public entities are affected.

Changes

Dependency version bump

Layer / File(s) Summary
Update workspace dependency revs
Cargo.toml
Updates the git rev for dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, and dashcore-rpc from c88264e... to 647fa98....

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • dashpay/platform#3757: Both PRs update the same [workspace.dependencies] git rev for the dashcore-related crates to different target revisions.
  • dashpay/platform#3973: Both PRs update the same rev pins for the Dash crate family in Cargo.toml.
  • dashpay/platform#4014: Both PRs continue a related rust-dashcore revision bump path for the same set of dependencies.

Suggested labels: ready for final review

Suggested reviewers: thepastaclaw, QuantumExplorer

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: bumping rust-dashcore to commit 647fa98.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build/rust-dashcore-647fa98

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

✅ Review complete (commit fe0f552)

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Source: reviewers = claude general opus; codex general gpt-5.5; verifier = claude opus; specialists = none; policy gate = review_policy.enforce_backport_prereq_policy.

This PR is a pure dependency bump of rust-dashcore from c88264e7 to 647fa982 across workspace Cargo.toml and Cargo.lock. Both agents independently verified the bump is consistent and found no defects; the upstream range only touches wallet-side (key-wallet) code and does not affect consensus-critical dpp/drive/drive-abci paths.

@lklimek lklimek merged commit 2a1ac4e into v4.1-dev Jul 6, 2026
16 checks passed
@lklimek lklimek deleted the build/rust-dashcore-647fa98 branch July 6, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants