Skip to content

test(swift-sdk): update address vectors to DIP-0018 after #4021 #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 1 commit into from
Jul 6, 2026
+14 −9
Merged

test(swift-sdk): update address vectors to DIP-0018 after #4021 #4024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/swift-sdk/SwiftTests/SwiftDashSDKTests/DataTransformersTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,12 @@ final class DataTransformersTests: XCTestCase {
}

func testParseAddressBech32m() {
// Valid testnet bech32m address
let address = "tdashevo1qz4242424242424242424242424242424g4dj6u7"
// A real DIP-0018 testnet platform address (tdash1...).
let address = "tdash1kzdl4c3apkekqevkqrzctgagv2v2ng5hysegt5x4"
let data = AddressTransformer.parseAddress(address)
// Should return data if Bech32m decoder works, nil otherwise
XCTAssertTrue(data == nil || data?.count == 21)
XCTAssertEqual(data?.count, 21, "a valid tdash1 address must decode to the 21-byte payload")
// The pre-DIP-0018 HRP is rejected.
XCTAssertNil(AddressTransformer.parseAddress("tdashevo1qz4242424242424242424242424242424g4dj6u7"))
}

func testParseAddressInvalid() {
Expand Down
14 changes: 9 additions & 5 deletions packages/swift-sdk/SwiftTests/SwiftDashSDKTests/ValidationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,19 @@ final class ValidationTests: XCTestCase {
}

func testValidateBech32mAddress_valid() {
// Valid testnet address (tdashevo1...)
// Using a well-formed bech32m address
let validTestnetAddress = "tdashevo1qz4242424242424242424242424242424g4dj6u7"
// A real DIP-0018 testnet platform address (tdash1..., 21-byte
// payload, valid bech32m checksum) — proof-verified on testnet.
let validTestnetAddress = "tdash1kzdl4c3apkekqevkqrzctgagv2v2ng5hysegt5x4"
XCTAssertTrue(AddressValidator.validateBech32mAddress(validTestnetAddress))
}

func testValidateBech32mAddress_invalid() {
// Wrong HRP
XCTAssertFalse(AddressValidator.validateBech32mAddress("bitcoin1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq"))
// Pre-DIP-0018 HRP ("tdashevo") — rejected since the DIP-0018
// decode fix; the canonical testnet HRP is "tdash".
XCTAssertFalse(
AddressValidator.validateBech32mAddress("tdashevo1qz4242424242424242424242424242424g4dj6u7"))
// No separator
XCTAssertFalse(AddressValidator.validateBech32mAddress("tdashevoqqqqqqqqqqq"))
// Empty
Expand All @@ -98,8 +102,8 @@ final class ValidationTests: XCTestCase {
let hexAddr = "00aaff11223344556677889900aabbccddeeff0011"
XCTAssertTrue(AddressValidator.validateAddress(hexAddr))

// Bech32m address (if valid)
let bech32mAddr = "tdashevo1qz4242424242424242424242424242424g4dj6u7"
// DIP-0018 bech32m address
let bech32mAddr = "tdash1kzdl4c3apkekqevkqrzctgagv2v2ng5hysegt5x4"
XCTAssertTrue(AddressValidator.validateAddress(bech32mAddr))

// Invalid
Expand Down
Loading