Commenting out verify goal for proper cucumber report generation.#1613
Open
Vipinofficial11 wants to merge 1 commit into
Open
Commenting out verify goal for proper cucumber report generation.#1613Vipinofficial11 wants to merge 1 commit into
Vipinofficial11 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the pom.xml to comment out the verify goal, aiming to allow Cucumber reports to generate even when tests fail. However, the reviewer pointed out that the integration-test goal was accidentally removed, which prevents integration tests from running. The reviewer provided a suggestion to retain the integration-test goal.
Comment on lines
+1202
to
+1203
| <!-- Commented out verify goal to allow Cucumber reports to generate correctly even when tests fail --> | ||
| <!-- <goal>verify</goal> --> |
There was a problem hiding this comment.
By commenting out the goals, the <goal>integration-test</goal> was accidentally removed. This prevents the maven-failsafe-plugin from running the integration tests altogether. To run the tests while allowing the Cucumber reports to generate, please retain the integration-test goal.
<goal>integration-test</goal>
<!-- Commented out verify goal to allow Cucumber reports to generate correctly even when tests fail -->
<!-- <goal>verify</goal> -->
Vipinofficial11
force-pushed
the
updateReleaseBranchForReports
branch
from
b0cbef0 to
105da5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the pom.xml to ensure that Cucumber test reports are generated even when there are test failures.
Currently, the verify goal in the maven-failsafe-plugin configuration causes the build to halt on test failures, which prevents the Cucumber report generation from completing. By commenting out the verify goal, the build will now proceed and generate the reports, which is crucial for debugging failures.