Repository navigation
Report DECIMAL precision and scale through database/sql - #513
Open
ajaykr0905 wants to merge 1 commit into
Open
ajaykr0905 wants to merge 1 commit into
ajaykr0905 wants to merge 1 commit into
Conversation
Assisted-by: OpenAI Codex Signed-off-by: Ajay Kumar <206070437+ajaykr0905@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement
driver.RowsColumnTypePrecisionScalefor both result backends sosql.ColumnType.DecimalSize()reports declared DECIMAL qualifiers. Non-decimal columns, invalid indexes, and incomplete Thrift qualifiers continue to returnok=false.Closes #500.
Evidence
RowsColumnTypePrecisionScale, so DECIMAL metadata returnedok=false.databricks_kernel-tagged suite passes; lint reports 0 issues; Linux and Darwin builds pass.No live Databricks warehouse call was made. Tests exercise the same Thrift qualifier and Arrow
Decimal128metadata consumed by the two rows implementations.Merge Danger
Door: Two-way
Blast Radius: Result metadata
The change only adds an optional
database/sql/drivermetadata interface. Scanned DECIMAL values and non-decimal metadata behavior are unchanged.