Validate OpenAPI spec payloads#51
Open
bernardassistant557-arch wants to merge 1 commit intodatagouv:mainfrom
Open
Validate OpenAPI spec payloads#51bernardassistant557-arch wants to merge 1 commit intodatagouv:mainfrom
bernardassistant557-arch wants to merge 1 commit intodatagouv:mainfrom
Conversation
bolinocroustibat
requested changes
Mar 25, 2026
|
|
||
| raise ValueError(f"Could not parse OpenAPI spec from {url} as JSON or YAML") | ||
| raise ValueError( | ||
| f"Could not parse OpenAPI spec from {url} as JSON or YAML object" |
Collaborator
There was a problem hiding this comment.
Let's keep a single-line raise to avoid unrelated formatting in the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
fetch_openapi_spec would happily return non-dict payloads (e.g., a plain string), which makes downstream usage fail later and produces confusing errors.
Reasoning
OpenAPI specs are defined as JSON/YAML objects. Enforcing that early keeps behavior predictable and surfaces bad specs immediately.
Changes
Testing