Repository navigation
fix: address five defects found reviewing the upstream feature stack (dddperth #208) - #29
Merged
JakeGinnivan merged 1 commit intoOct 19, 2026
Conversation
Upstreamed from dddwa/dddperth#208. - fix(admin): revalidate planner data only after queued edits. Replaces the edge-triggered fix carried into `useQueuedSave` when #24 was rebased over #21; the fork fixed the same loop with a `needsRevalidation` ref, and keeping one version on both sides stops the next `/core-pull` conflicting on this file. - fix(agenda): serialize shortlist reports to preserve identity and order - fix(volunteers): reject assignments across overlapping sessions - fix(sponsors): preserve Jira paragraph and line breaks - fix(sponsors): preserve portal saves made during Jira synchronization Every file is byte-identical to the fork's post-#208 copy except `jira-client.test.ts`, which keeps upstream's `describe.runIf(conferenceManifest.sponsorPortal)` guards. The new rich-text test builds its own Jira config, so it runs in the stub.
JakeGinnivan
deleted the
jakeginnivan/upstream-fork-pr-208-review-fixes
branch
October 19, 2026 03:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreamed from dddwa/dddperth#208.
Why this one matters for syncing
When #24 was rebased over #21 (the agenda planner's endless revalidation loop), #24 had moved that logic into the shared
useQueuedSavehook, which still had the bug. So the rebase carried #21's edge-triggered fix into the hook. Meanwhile the fork fixed the same loop independently, with aneedsRevalidationref. Left alone, the next/core-pullwould conflict onuse-queued-save.ts, with two different fixes in the same lines. This PR takes the fork's version, so both sides match.The five fixes
useQueuedSave, plus a new test)use-my-agenda, plus a new test)Upstreamed vs left behind
core/; nothing outside it and no baselinesjira-client.test.tskeeps upstream'sdescribe.runIf(conferenceManifest.sponsorPortal)guards (added during the catch-up). #208's new rich-text test builds its own Jira config, so it runs unguarded in the stub.Testing
tscclean; 739 unit tests pass (38 skipped, the same asmain, including the 4 guarded Jira tests); eslint clean; build passespnpm vrpasses against the existing baselines with none changed, as expected: no rendered output changes. WebKit tablet was re-run after two 35s capture timeouts.After this and #27 merge, the fork's next
/core-pullshould be close to a no-op for these files. I haven't done a trial pull to confirm it.🤖 Generated with Claude Code