Repository navigation
feat(agenda): close agenda building once the conference is over - #212
Merged
Merged
Conversation
Picking talks stops the day after the conference. The My agenda link stays for anyone who picked talks in this browser and is hidden for everyone else, and /agenda/my says the conference is over instead of pointing at a + button that no longer exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Building an agenda closes once the conference is over. People who already picked talks keep their link to
/agenda/my; everyone else stops seeing it./agenda/mystill lists existing picks and exports the .ics. Its empty state after the conference now says the conference is over instead of telling people to use a + button that no longer exists.Evidence
New e2e cases in
e2e/my-agenda.spec.ts. They set the date override to 2026-10-10, a week after the fixture conference:my-agenda.spec.ts+date-states.spec.ts, chromium and chromium-light: 34 passed.Merge Danger
Door: two-way
Only a loader flag and conditional rendering change. Picks in localStorage aren't touched, so reverting brings everything back as it was.
Blast Radius: small
It only affects the current year's
/agendaand/agenda/myonce theconference-overstate starts, which is the day after the conference./api/agenda/shortlistis unchanged and still accepts POSTs after the conference, but the UI no longer sends any adds.