Repository navigation
feat(brand): move the logo and hero Ds into conference/brand/ - #216
Merged
JakeGinnivan merged 1 commit intoOct 30, 2026
Merged
Conversation
Takes dddwa/ddd-core#31 into core/ ahead of the next /core-pull: the wordmark and the three hero marks now come from `brandAssets` in the build manifest rather than core/website/app/images/. Perth's four SVGs move, unchanged, into conference/brand/, so the site renders identically — the fork's visual baselines pass without regeneration. The core/ diff matches ddd-core#31 byte for byte (bar core/CLAUDE.md, whose surrounding text already differed), so the later subtree pull of that PR brings no conflicting content.
JakeGinnivan
force-pushed
the
jakeginnivan/fork-owned-brand-assets-logo-and-hero-marks
branch
from
October 30, 2026 04:14
1d44505 to
48eb520
Compare
JakeGinnivan
deleted the
jakeginnivan/fork-owned-brand-assets-logo-and-hero-marks
branch
October 30, 2026 04:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fork side of dddwa/ddd-core#31 (closes dddwa/ddd-core#13). I've applied that PR's
core/changes here directly, so the next/core-pullbrings the same content and doesn't conflict.Summary
Perth's wordmark and hero Ds move out of
core/and into the fork, unchanged, and the build manifest points at them.How the change works is in ddd-core#31. Writing this fork side turned up one extra fix, now on that PR as well: the plugin adds the brand directory to Vite's
fs.allow. In the fork the files sit outsidecore/, so vitest refused to load them (Denied ID .../conference/brand/logo.svg?react) and the two portal test files failed. The standalone core build never hits this.Every changed
core/file matches ddd-core#31 byte for byte, exceptvite.config.ts(the fork override), which gets the same hunks. Both PRs start from ddd-core8a6c80a, which #217 pulled in.Evidence
core/.After:
pnpm vr: 108 passed with no baseline changes. The site renders the same pixels from the new location.fs.allowfix,vitest runhad 2 failing test files (the speaker and sponsor portals). With it: 100 files, 945 tests passed (rebased onto chore(core): pull ddd-core through #30 and link core's skills #217).tsc(website and conference) andeslintpass. The production build's_virtual_conference-brand-*.jscontains Perth's colours.Merge Danger
Door: two-way
Blast Radius: header
It covers the logo in the header, footer and portal, plus the home-page hero. The visual suite shows no pixel change. Merge this before or with the
/core-pullthat brings in ddd-core#31. Pulling #31 without it would break the typecheck, becausebrandAssetsis required.