Skip to content

feat(brand): move the logo and hero Ds into conference/brand/ - #216

Merged
JakeGinnivan merged 1 commit into
mainfrom
jakeginnivan/fork-owned-brand-assets-logo-and-hero-marks
Oct 30, 2026
Merged

JakeGinnivan merged 1 commit into
mainfrom
jakeginnivan/fork-owned-brand-assets-logo-and-hero-marks

Conversation

@JakeGinnivan

@JakeGinnivan JakeGinnivan commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This is the fork side of dddwa/ddd-core#31 (closes dddwa/ddd-core#13). I've applied that PR's core/ changes here directly, so the next /core-pull brings the same content and doesn't conflict.

Summary

Perth's wordmark and hero Ds move out of core/ and into the fork, unchanged, and the build manifest points at them.

 conference/
+├── brand/
+│   ├── logo.svg                 # DDD PERTH wordmark (was core/website/app/images/svg/)
+│   └── d-{green,pink,purple}.svg  # hero marks (was core/website/app/images/hero/)
 └── build-manifest.ts
+      brandAssets: { logo, heroMarks: [d-green, d-pink, d-purple] }
 core/website/
-├── app/images/svg/logo.svg
-├── app/images/hero/d-*.svg
+└── vite-plugins/conference-brand.ts   # → virtual:conference-brand

How the change works is in ddd-core#31. Writing this fork side turned up one extra fix, now on that PR as well: the plugin adds the brand directory to Vite's fs.allow. In the fork the files sit outside core/, so vitest refused to load them (Denied ID .../conference/brand/logo.svg?react) and the two portal test files failed. The standalone core build never hits this.

Every changed core/ file matches ddd-core#31 byte for byte, except vite.config.ts (the fork override), which gets the same hunks. Both PRs start from ddd-core 8a6c80a, which #217 pulled in.

Evidence

  • Before: the fork had to keep Perth's artwork inside core/.
    After: pnpm vr: 108 passed with no baseline changes. The site renders the same pixels from the new location.
  • Without the fs.allow fix, vitest run had 2 failing test files (the speaker and sponsor portals). With it: 100 files, 945 tests passed (rebased onto chore(core): pull ddd-core through #30 and link core's skills #217).
  • tsc (website and conference) and eslint pass. The production build's _virtual_conference-brand-*.js contains Perth's colours.

Merge Danger

Door: two-way

Blast Radius: header

It covers the logo in the header, footer and portal, plus the home-page hero. The visual suite shows no pixel change. Merge this before or with the /core-pull that brings in ddd-core#31. Pulling #31 without it would break the typecheck, because brandAssets is required.

Takes dddwa/ddd-core#31 into core/ ahead of the next /core-pull: the
wordmark and the three hero marks now come from `brandAssets` in the build
manifest rather than core/website/app/images/. Perth's four SVGs move,
unchanged, into conference/brand/, so the site renders identically — the
fork's visual baselines pass without regeneration.

The core/ diff matches ddd-core#31 byte for byte (bar core/CLAUDE.md, whose
surrounding text already differed), so the later subtree pull of that PR
brings no conflicting content.
@JakeGinnivan
JakeGinnivan force-pushed the jakeginnivan/fork-owned-brand-assets-logo-and-hero-marks branch from 1d44505 to 48eb520 Compare October 30, 2026 04:14
@JakeGinnivan
JakeGinnivan merged commit 0beb1af into main Oct 30, 2026
3 checks passed
@JakeGinnivan
JakeGinnivan deleted the jakeginnivan/fork-owned-brand-assets-logo-and-hero-marks branch October 30, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forks have to overwrite core brand assets in place

1 participant