Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Allow Dependabot's proxy to access Proton AG's public sparse Cargo registry (
rust-registry.proton.me) when outbound egress allowlist enforcement is enabled.The existing Cargo defaults cover crates.io and other registries/mirrors, but not Proton's public registry, which publishes crates including
pvpnclientandmuon. This PR adds its exact hostname toecosystem_default_domains.cargo.Anything you want to highlight for special attention from reviewers?
The allowlist entry is an exact hostname, not a
.proton.mesuffix or wildcard. A regression test verifies thatevil.rust-registry.proton.meremains blocked.The registry's sparse index configuration specifies the download URL:
{"dl": "https://rust-registry.proton.me/downloads/{crate}@{version}.crate"}Both the sparse index and crate archives use the same hostname. A
curl.exe -ILrequest tohttps://rust-registry.proton.me/downloads/muon@5.0.1.cratereturned HTTP 200 without a redirect, so the checked download did not require another allowlisted host.How will you know you've accomplished your goal?
The added regression cases verify:
https://rust-registry.proton.me/index/config.jsonis permitted as a public registry endpoint.https://evil.rust-registry.proton.me/payloadis rejected, preserving exact-host matching.Testing
config.jsondownload URL and a successful HTTP 200 response for a sample.cratedownload, with no redirect.The regression tests exercise proxy allowlist behavior, not an end-to-end Cargo update. Separately, the
triagelabeler workflow failed to apply theallowlistlabel; this was unrelated to a code test.Checklist